You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by georgeslegros <gi...@git.apache.org> on 2016/05/09 13:01:53 UTC
[GitHub] cordova-windows pull request: Fix build result when using --bundle...
GitHub user georgeslegros opened a pull request:
https://github.com/apache/cordova-windows/pull/175
Fix build result when using --bundle and multiple architectures
Hello,
This small modification aims at avoiding error messages when building appxbundle with multiple architectures.
The previous code was not taking archs into account.
Cheers,
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/georgeslegros/cordova-windows master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #175
----
commit 97cb6c8cc94608254b722df080fa9a659593b27e
Author: Georges Legros <gl...@opinum.com>
Date: 2016-05-09T12:59:21Z
Fix build result when using --bundle and multiple architectures
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Fix build result when using --bundle...
Posted by CSharpFan <gi...@git.apache.org>.
Github user CSharpFan commented on the pull request:
https://github.com/apache/cordova-windows/pull/175#issuecomment-218070737
`npm install lodash --save`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request #175: Fix build result when using --bundle and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Fix build result when using --bundle...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/175#issuecomment-221026158
@georgeslegros Thanks for this fix!
It will be great to not add a dependency to lodash for this - also as you have not added it to package.json - our tests are failing.
It will be great if you can create a JIRA here about the issue with details on how to reproduce it - this will help in testing this fix: https://issues.apache.org/. Please follow instructions here on how to file a JIRA: http://cordova.apache.org/contribute/issues.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: Fix build result when using --bundle...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-windows/pull/175#issuecomment-217858244
## [Current coverage][cc-pull] is **16.35%**
> Merging [#175][cc-pull] into [master][cc-base-branch] will decrease coverage by **-57.06%**
```diff
@@ master #175 diff @@
==========================================
Files 14 13 -1
Lines 1862 1810 -52
Methods 342 337 -5
Messages 0 0
Branches 379 364 -15
==========================================
- Hits 1367 296 -1071
- Misses 495 1514 +1019
Partials 0 0
```
1. 11 files (not in diff) in `template/cordova/lib` were modified. [more](https://codecov.io/gh/apache/cordova-windows/commit/e0c717a36528c253ff0b663e98a63f2faf101f0b/changes?src=pr#74656D706C6174652F636F72646F76612F6C6962)
- Misses `+1001`
- Hits `-1001`
1. File `...rdova/lib/package.js` was modified. [more](https://codecov.io/gh/apache/cordova-windows/commit/e0c717a36528c253ff0b663e98a63f2faf101f0b/changes?src=pr#74656D706C6174652F636F72646F76612F6C69622F7061636B6167652E6A73)
- Misses `+31`
- Partials `0`
- Hits `-31`
1. File `...e/cordova/lib/run.js` (not in diff) was deleted. [more](https://codecov.io/gh/apache/cordova-windows/commit/e0c717a36528c253ff0b663e98a63f2faf101f0b/changes?src=pr#74656D706C6174652F636F72646F76612F6C69622F72756E2E6A73)
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [b8b636c...e0c717a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-windows/compare/b8b636cd097c8cf40e1313075ef5195cdcf247f8...e0c717a36528c253ff0b663e98a63f2faf101f0b
[cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/175?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org