You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by "cdmikechen (via GitHub)" <gi...@apache.org> on 2023/05/21 06:35:06 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #1064: SUBMARINE-1363. Git-Sync container can not pull specified branch or main codes
cdmikechen opened a new pull request, #1064:
URL: https://github.com/apache/submarine/pull/1064
### What is this PR for?
Make submarine support for pulling git with branch, username and password.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Submarine Server
* [x] - e2e test
* [x] - Submarine Workbench
* [ ] - Submarine API Documents
* [ ] - Submarine SDK
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1363
### How should this be tested?
cicd
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? Yes
* Does this need new documentation? Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #1064: SUBMARINE-1363. Git-Sync container can not pull specified branch or main codes
Posted by "cdmikechen (via GitHub)" <gi...@apache.org>.
cdmikechen commented on PR #1064:
URL: https://github.com/apache/submarine/pull/1064#issuecomment-1602513103
I have found that most of the current integration tests (e.g. https://github.com/apache/submarine/actions/runs/5345025163/jobs/9690142792?pr=1064) fail with error `ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device` when installing tf dependencies.
<img width="1884" alt="image" src="https://github.com/apache/submarine/assets/12069428/7d2fe5b4-d31a-4bac-b428-59a62e24c8e0">
I have used the `df` command in the CI step to output the storage of the current container and have not yet found any particular exceptions:
<img width="981" alt="image" src="https://github.com/apache/submarine/assets/12069428/53647819-268b-4ff6-b7d0-057964bfc9eb">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #1064: SUBMARINE-1363. Git-Sync container can not pull specified branch or main codes
Posted by "cdmikechen (via GitHub)" <gi...@apache.org>.
cdmikechen commented on PR #1064:
URL: https://github.com/apache/submarine/pull/1064#issuecomment-1602548197
In some CI workflows, the following error also occurs:
<img width="1887" alt="image" src="https://github.com/apache/submarine/assets/12069428/8d131a3b-c9e6-4779-8e12-b68d63e5433c">
This error started today and I am suspecting that it may have something to do with a network problem when pulling tensorflow files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #1064: SUBMARINE-1363. Git-Sync container can not pull specified branch or main codes
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1064: SUBMARINE-1363. Git-Sync container can not pull specified branch or main codes
URL: https://github.com/apache/submarine/pull/1064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #1064: SUBMARINE-1363. Git-Sync container can not pull specified branch or main codes
Posted by "cdmikechen (via GitHub)" <gi...@apache.org>.
cdmikechen commented on PR #1064:
URL: https://github.com/apache/submarine/pull/1064#issuecomment-1603476742
@pingsutw
Hi~
I have fixed the CI related issues and all checks are now OK. You can review this PR if it is convenient for you.
To deal with the problem of `no space left` error when installing pip dependencies, I have moved up the pip install steps and cleared the pip cache after installation. This seems to have eliminated the problem for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #1064: [WIP] SUBMARINE-1363. Git-Sync container can not pull specified branch or main codes
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1064:
URL: https://github.com/apache/submarine/pull/1064#issuecomment-1556098088
## [Codecov](https://app.codecov.io/gh/apache/submarine/pull/1064?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1064](https://app.codecov.io/gh/apache/submarine/pull/1064?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e892ba9) into [master](https://app.codecov.io/gh/apache/submarine/commit/387a0eac89f7a08de2b5972eb35e5851d27b3ee2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (387a0ea) will **decrease** coverage by `31.51%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1064 +/- ##
===========================================
- Coverage 75.98% 44.47% -31.51%
===========================================
Files 119 119
Lines 5000 4735 -265
===========================================
- Hits 3799 2106 -1693
- Misses 1201 2629 +1428
```
| Flag | Coverage Δ | |
|---|---|---|
| python-integration | `?` | |
| python-unit | `44.47% <ø> (-8.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 63 files with indirect coverage changes](https://app.codecov.io/gh/apache/submarine/pull/1064/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org