You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/15 13:37:43 UTC
[GitHub] [arrow] kou opened a new pull request, #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
kou opened a new pull request, #33674:
URL: https://github.com/apache/arrow/pull/33674
# Which issue does this PR close?
Closes #15256
# What changes are included in this PR?
It writes all data into one directory.
# Are these changes tested?
Yes.
# Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399204515
I'm OK with `NoPartitioning`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1383152913
:warning: GitHub issue #15256 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cpcloud closed pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud closed pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
URL: https://github.com/apache/arrow/pull/33674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1383152912
:warning: GitHub issue #15256 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399996634
> I'm not sure how much this scenario is tested.
From Python that is certainly tested, since if you don't pass any partitioning columns in `pyarrow.dataset.write_dataset`, we create a default partitioning object with an empty schema (and the default is DirectoryPartitioning).
---
> Maybe `ChunkPartitioning` (since files will still potentially be broken into chunks if needed)?
The downside of that is that also for other schemes like HivePartitioning files _also_ get broken into chunks in addition to the hive-like directories, so that is not a distinguishing feature.
Maybe the original "Default" partitioning is a decent name in the end, since "default" is ambiguous enough to avoid such conflicting interpretations of "flat" or "no" .. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1492671376
OK. I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1492601305
> @westonpace OK! We need to find a consensus approach to resolve this.
> How about returning a `DictionaryPartitioning` with an empty schema (like PyArrow) by `Partitioning::Default()` instead of a `DefaultPartitioning` defined internally?
Yes. That will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399269134
@pitrou can be tiebreaker then :). I don't like `FlatPartitioning` (I would think this was equivalent to filename partitioning) and Joris is not a fan of `NoPartitioning` (since he would expect no files). Maybe `ChunkPartitioning` (since files will still potentially be broken into chunks if needed)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399361870
Can we use `FilenamePartitioning` with an empty schema as the default partitioning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399263144
@jorisvandenbossche you might be thinking of FilenamePartitioning (which I forgot to mention) which gives you:
```
x=7_chunk0.parquet
x=7_chunk1.parquet
x=10_chunk0.parquet
```
This partitioning is only going to split up files when there are too many rows. So, if you set `max_rows_per_file` to unlimited then you would get a single file for each write. The output will be:
```
chunk0.parquet
chunk1.parquet
chunk2.parquet
```
...and there will be no meaningful information in the filenames.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1492265858
I didn't mean to reopen. @kou can reopen if desired. However, I do think it would be good to resolve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #33674:
URL: https://github.com/apache/arrow/pull/33674#discussion_r1156734075
##########
cpp/src/arrow/dataset/partition_test.cc:
##########
@@ -189,6 +189,12 @@ TEST_F(TestPartitioning, Partition) {
expected_expressions);
}
+TEST_F(TestPartitioning, DefaultPartitioningIsDirectoryPartitioning) {
+ auto partitioning = Partitioning::Default();
+ ASSERT_EQ(partitioning->type_name(), "directory");
+ AssertSchemaEqual(partitioning->schema(), schema({}));
+}
+
Review Comment:
Sure!
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1385657926
"Flat" sounds good to me.
cc @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399266477
No, I was thinking about the latter.
How I interpret it, with the datasets API, we _always_ create a partitioned dataset, since we always create a (possibly nested) directory of files (in contrast to the Parquet ``write_table`` API which writes single files). Even if the different files / parts have no meaningful additional information embedded in the name or path, I personally still consider that as partitioned (but again, that's my interpretation, I don't know if that's the common interpretation of "partitioned")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cpcloud commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1490557021
@kou Thanks for the PR! This has been open for some months now without activity, so I'm going to close it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on code in PR #33674:
URL: https://github.com/apache/arrow/pull/33674#discussion_r1156481500
##########
cpp/src/arrow/dataset/partition_test.cc:
##########
@@ -189,6 +189,12 @@ TEST_F(TestPartitioning, Partition) {
expected_expressions);
}
+TEST_F(TestPartitioning, DefaultPartitioningIsDirectoryPartitioning) {
+ auto partitioning = Partitioning::Default();
+ ASSERT_EQ(partitioning->type_name(), "directory");
+ AssertSchemaEqual(partitioning->schema(), schema({}));
+}
+
Review Comment:
Can you also add a test to verify directory partitioning works with an empty schema?
```
TEST_F(TestPartitioning, DirectoryPartitioningEmpty) {
partitioning_ = std::make_shared<DirectoryPartitioning>(schema({}));
written_schema_ = partitioning_->schema();
// No partitioning info
AssertParse("", literal(true));
// Files can be in subdirectories
AssertParse("/foo/", literal(true));
// Partitioning info is discarded on write
AssertFormat(equal(field_ref("alpha"), literal(7)), "");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1499328297
Benchmark runs are scheduled for baseline = c21986302e35f48feca5e1dbd92a7130337b20e3 and contender = 8d8d21ff9bddf3046e3438dee60deeb975cbf3a4. 8d8d21ff9bddf3046e3438dee60deeb975cbf3a4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7e3b0c830a34fb1ad655e66ffd3b2e7...0761025828ac423797b2e4cada6aabd6/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/110f01cd5de24423b264e1e64eff4239...d8fe96e2a5e942589dcd916121fc85bf/)
[Failed :arrow_down:0.0% :arrow_up:0.26%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a174611153194c988a6be9e06f944d2c...067048dae35a4c0bb41bb8cbfb7bf301/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa01686d701f4256b9b17b3463894a61...6402aa4c64ef4e6fa158e95d2ea55361/)
Buildkite builds:
[Finished] [`8d8d21ff` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2640)
[Failed] [`8d8d21ff` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2673)
[Failed] [`8d8d21ff` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2638)
[Failed] [`8d8d21ff` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2664)
[Finished] [`c2198630` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2639)
[Failed] [`c2198630` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2671)
[Finished] [`c2198630` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2633)
[Failed] [`c2198630` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2662)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399569368
I suppose all partitioning schemes, given an empty schema, should behave exactly the same. That might be a better solution.
For example, someone working with Spark will always want to use the hive partitioning scheme. Sometimes there might not be any partitioning columns. They still would think they are working with "the hive scheme with no columns".
I'm not sure how much this scenario is tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1492978884
@westonpace Could you review this?
CI failures are unrelated:
* R failures are caused by #34711
* MinGW failures will be fixed by #34768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace closed pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
URL: https://github.com/apache/arrow/pull/33674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1399212587
> I think I'd prefer "none" over "flat". "flat" implies to me that something is still happening. E.g. there is still some kind of partitioning.
There also _is_ still some kind of partitioning, I think? I.e. a single flat directory? I would interpret "No" partitioning as a single file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1385199065
Shouldn't this be given a more descriptive name than "default"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1398809379
I'm fine with default. I think I'd prefer "none" over "flat". "flat" implies to me that something is still happening. E.g. there is still some kind of partitioning.
We currently have `HivePartitioning` and `DirectoryPartitioning` so how about `NoPartitioning`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1492597575
@westonpace OK! We need to find a consensus approach to resolve this.
How about returning a `DictionaryPartitioning` with an empty schema (like PyArrow) by `Partitioning::Default()` instead of a `DefaultPartitioning` defined internally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #33674:
URL: https://github.com/apache/arrow/pull/33674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1498142573
CI failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by GitBox <gi...@apache.org>.
kou commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1385615786
"flat"? "nothing"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33674: GH-15256: [C++][Dataset] Add support for writing with Partitioning::Default()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #33674:
URL: https://github.com/apache/arrow/pull/33674#issuecomment-1383152904
* Closes: #15256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org