[GitHub] [incubator-openwhisk-deploy-kube] neerajmangal commented on a change in pull request #447: Add Support to store Openwhisk Component Images in Hosted Docker Registry.

[GitBox <gi...@apache.org>]

neerajmangal commented on a change in pull request #447: Add Support to store Openwhisk Component Images in Hosted Docker Registry.
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/447#discussion_r272455680
 
 

 ##########
 File path: helm/openwhisk/templates/_invoker-helpers.tpl
 ##########
 @@ -33,8 +33,12 @@
 
 {{- define "openwhisk.docker_pull_runtimes" -}}
 - name: docker-pull-runtimes
-  imagePullPolicy: {{ .Values.utility.imagePullPolicy | quote }}
+{{- if .Values.docker.usePrivateRegistry }}
 
 Review comment:
   Hi @dgrove-oss, I used this based on the usePrivateRegistry flag keeping a scenario where the user won't like to use private Docker registry for component images but want to use only for runtime images (like today's behavior).
   
   Though using your method is better, in that case, one has to put all component + runtime images in Private Docker Registry is registry name is provided. Let me know your thoughts, I will modify it based on your suggestion. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services