You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2016/12/17 01:45:59 UTC

[jira] [Resolved] (BOOKKEEPER-966) change the bookieServer cmdline to make conf-file and option co-exist

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo resolved BOOKKEEPER-966.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 4.5.0

Issue resolved by merging pull request 75
            [https://github.com/apache/bookkeeper/pull/75]

            {noformat}
            commit 73edd4a99191d3c710b24a85eed3e2dbcd0a93bc
Author:     jiazhai <ji...@emc.com>
AuthorDate: Fri Dec 16 17:45:11 2016 -0800
Commit:     Sijie Guo <si...@apache.org>
CommitDate: Fri Dec 16 17:45:11 2016 -0800

    BOOKKEEPER-966: change bookieServer cmdline to make conf-file and option co-exist
    
    Currently, when using bookieServer cmdline to start a bookie, you will either give it a cofiguration file by "-c booke.conf"; or add some options like "<bookie_port> <zk_servers> <journal_dir> <ledger_dir [ledger_dir]>" in a fix sequential.
    It may not satisfy some of the requirement. So changed it to be co-exist for configuration file and options.
    
    By this change, it will first use settings in configuration file; and then use options to overwrite some of the settings, if there are some options provided.
    
    Here is an example after this change:
    ```
    BookieServer -c bookie.conf -z localhost:2181 -m /bookkeeper/ledgers -p 3181 -j /mnt/journal -l "/mnt/ledger1 /mnt/ledger2 /mnt/ledger3”
    ```
    Here, in this command:
    -z is for “Zookeeper client instance”;
    -m is for "Zookeeper ledgers root path for bookies";
    -p is for "bookie service port exported";
    -j is for "bookie journal directory";
    -l is for "bookie ledgers directories".
    
    Author: jiazhai <ji...@emc.com>
    Author: jiazhai <ji...@users.noreply.github.com>
    
    Reviewers: Enrico Olivelli <eo...@gmail.com>, Sijie Guo <si...@apache.org>
    
    Closes #75 from jiazhai/BOOKKEEPER-966

            {noformat}
            

> change the bookieServer cmdline to make conf-file and option co-exist
> ---------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-966
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-966
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Jia Zhai
>            Assignee: Jia Zhai
>             Fix For: 4.5.0
>
>
> Currently, when using bookieServer cmdline to start a bookie, you will either give it a cofiguration file by "-c booke.conf"; or add some options like "<bookie_port> <zk_servers> <journal_dir> <ledger_dir [ledger_dir]>" in a fix sequential.
> It may not satisfy some of the requirement. So changed it to be co-exist for configuration file and options.
> By this change, it will first use settings in configuration file; and then use options to overwrite some of the settings, if there are some options provided.
> Here is an example after this change:
> BookieServer -c bookie.conf -z localhost:2181 -m /bookkeeper/ledgers -p 3181 -j /mnt/journal -l "/mnt/ledger1 /mnt/ledger2 /mnt/ledger3”
> Here, in this command:
> -z is for “Zookeeper client instance”;
> -m is for "Zookeeper ledgers root path for bookies";
> -p is for "bookie service port exported";
> -j is for "bookie journal directory";
> -l is for "bookie ledgers directories".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)