[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #708: DISPATCH-1490 - remove old-user-guide dir

[GitBox <gi...@apache.org>]

bhardesty commented on a change in pull request #708: DISPATCH-1490 - remove old-user-guide dir
URL: https://github.com/apache/qpid-dispatch/pull/708#discussion_r396666373
 
 

 ##########
 File path: docs/books/CMakeLists.txt
 ##########
 @@ -34,16 +33,10 @@ if (ASCIIDOCTOR_EXE)
     execute_process (
       COMMAND ${CMAKE_COMMAND} -E copy_if_different
       ${CMAKE_CURRENT_SOURCE_DIR}/${file}
-      ${CMAKE_CURRENT_BINARY_DIR}/${file}
+      ${CMAKE_CURRENT_BINARY_DIR}/user-guide/${file}
 
 Review comment:
   @ganeshmurthy can you please verify this? Currently, if you run "make docs", the images in user-guide/index.html are all broken. This is because the images/ dir is created one level up from where index.html expects it to be. This just ensures that the images/ dir is created where index.html expects.
   
   With this change, when I run "make docs", the images are in the correct location and they all show up in the doc as they should. However, I'm not sure if this change affects any of the make tooling for updating the website and/or creating new qpid-dispatch releases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org