You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pussuw (via GitHub)" <gi...@apache.org> on 2025/03/13 10:13:29 UTC
[PR] arch/mcx-nxxx: Add register definitions for SYSCON_CLOCKCTRL and LPTMR [nuttx]
pussuw opened a new pull request, #15986:
URL: https://github.com/apache/nuttx/pull/15986
## Summary
This adds memory mapped register definitions for:
- SYSCON_CLOCKCTRL (Controls internal FRO output)
- LPTMR (Low Power Timer)
## Impact
Code impact is adding register definitions to control hardware, no new executable code, only headers.
User impact, build impact etc. are none
## Testing
None, as no testing is needed (there is no executable code added).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/mcx-nxxx: Add register definitions for SYSCON_CLOCKCTRL and LPTMR [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen merged PR #15986:
URL: https://github.com/apache/nuttx/pull/15986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/mcx-nxxx: Add register definitions for SYSCON_CLOCKCTRL and LPTMR [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #15986:
URL: https://github.com/apache/nuttx/pull/15986#issuecomment-2722880142
Thanks @pussuw! Remember to fill in the Commit Description and Sign Off :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/mcx-nxxx: Add register definitions for SYSCON_CLOCKCTRL and LPTMR [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15986:
URL: https://github.com/apache/nuttx/pull/15986#issuecomment-2720713360
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
__Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
No. While the PR may not introduce executable code, it *does* introduce new header files that define how the system interacts with hardware. Therefore, testing is absolutely required to verify the correctness of these register definitions. The "Testing" section should describe how the developer validated that these definitions accurately reflect the hardware registers. This might involve:
* **Unit Tests:** Even without executable code affecting functionality, unit tests can be written to verify that the register addresses and bitfield definitions are correct.
* **Hardware Tests:** The most reliable test would involve writing a simple application that uses the new register definitions to interact with the hardware and confirming the expected behavior. This would catch potential errors like incorrect bit offsets or register addresses. Even a simple test that reads and writes back a value to a register would be a significant improvement.
* **Static Analysis:** Tools can be used to check for potential issues like overlapping bitfields or incorrect data types.
The developer needs to provide evidence that the register definitions are correct. Simply stating "no testing is needed" is insufficient and makes the PR incomplete according to the NuttX requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org