You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "klsince (via GitHub)" <gi...@apache.org> on 2023/06/13 17:57:57 UTC
[GitHub] [pinot] klsince opened a new pull request, #10906: pull up awssdk version to top pom.xml
klsince opened a new pull request, #10906:
URL: https://github.com/apache/pinot/pull/10906
a bit cleanup for the aws sdk version as set in pom.xml files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10906: pull up awssdk version to top pom.xml
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10906:
URL: https://github.com/apache/pinot/pull/10906#discussion_r1230295657
##########
pom.xml:
##########
@@ -159,7 +159,7 @@
<jmh.version>1.26</jmh.version>
<audienceannotations.version>0.13.0</audienceannotations.version>
<clp-ffi.version>0.4.3</clp-ffi.version>
-
+ <aws.sdk.version>2.20.83</aws.sdk.version>
Review Comment:
technically speaking we dont need aws sdk if we dont enable the plugin. we can add a comment here (or not, i dont think that's too biggy)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #10906: pull up awssdk version to top pom.xml
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #10906:
URL: https://github.com/apache/pinot/pull/10906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10906: pull up awssdk version to top pom.xml
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10906:
URL: https://github.com/apache/pinot/pull/10906#issuecomment-1589876339
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10906?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10906](https://app.codecov.io/gh/apache/pinot/pull/10906?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3e50513) into [master](https://app.codecov.io/gh/apache/pinot/commit/0420414fc2a5408dc7aa32fdb9d359763fc3cb34?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0420414) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10906 +/- ##
=======================================
Coverage 0.11% 0.11%
=======================================
Files 2186 2186
Lines 117493 117493
Branches 17762 17762
=======================================
Hits 137 137
Misses 117336 117336
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `0.00% <ø> (ø)` | |
| integration2temurin11 | `0.00% <ø> (?)` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `0.00% <ø> (ø)` | |
| unittests1temurin17 | `0.00% <ø> (ø)` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `0.11% <ø> (ø)` | |
| unittests2temurin17 | `0.11% <ø> (ø)` | |
| unittests2temurin20 | `0.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org