You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2009/10/10 00:56:31 UTC

[jira] Created: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
---------------------------------------------------------

                 Key: PIG-1009
                 URL: https://issues.apache.org/jira/browse/PIG-1009
             Project: Pig
          Issue Type: Bug
            Reporter: Olga Natkovich


OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates reassigned PIG-1009:
-------------------------------

    Assignee: Olga Natkovich

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766303#action_12766303 ] 

Hadoop QA commented on PIG-1009:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12422166/PIG-1009.patch
  against trunk revision 825601.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/83/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/83/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/83/console

This message is automatically generated.

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1009:
--------------------------------

    Status: Open  (was: Patch Available)

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1009:
--------------------------------

    Status: Patch Available  (was: Open)

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766313#action_12766313 ] 

Daniel Dai commented on PIG-1009:
---------------------------------

+1, target findbugs warnings suppressed. 

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1009:
--------------------------------

    Status: Patch Available  (was: Open)

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766144#action_12766144 ] 

Daniel Dai commented on PIG-1009:
---------------------------------

+1, target findbugs warnings suppressed. 

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1009:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765933#action_12765933 ] 

Hadoop QA commented on PIG-1009:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12422166/PIG-1009.patch
  against trunk revision 825375.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/81/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/81/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/81/console

This message is automatically generated.

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1009) FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1009:
--------------------------------

    Attachment: PIG-1009.patch

> FINDBUGS: OS_OPEN_STREAM: Method may fail to close stream
> ---------------------------------------------------------
>
>                 Key: PIG-1009
>                 URL: https://issues.apache.org/jira/browse/PIG-1009
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG-1009.patch
>
>
> OS 	org.apache.pig.impl.io.FileLocalizer.parseCygPath(String, int) may fail to close stream
> OS 	org.apache.pig.impl.logicalLayer.parser.QueryParser.which(String) may fail to close stream
> OS 	org.apache.pig.impl.util.PropertiesUtil.loadPropertiesFromFile(Properties) may fail to close stream
> OS 	org.apache.pig.Main.configureLog4J(Properties, PigContext) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream
> OS 	org.apache.pig.tools.parameters.PreprocessorContext.executeShellCommand(String) may fail to close stream

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.