You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/27 13:13:49 UTC

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

fgerlits commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r859781765


##########
aptitude.sh:
##########
@@ -23,7 +23,7 @@ verify_enable_platform(){
 add_os_flags() {
     CC=gcc
     CXX=g++
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* ]] && [ "$OS_MAJOR" -lt 22 ]; then

Review Comment:
   It's a bit weird to mix `[[ ]]` and `[ ]`.  Why not 
   ```suggestion
       if [[ "$OS" = Ubuntu* && "$OS_MAJOR" -lt 22 ]]; then
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org