You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by masonicboom <gi...@git.apache.org> on 2015/04/26 06:29:19 UTC
[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos
GitHub user masonicboom opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/113
fix install on amazon-fireos
I'm shooting in the dark, here, so someone knowledgable please check this.
I was previously getting this error:
Failed to install 'cordova-plugin-file':Error: Uh oh!
".../plugins/cordova-plugin-file/src/android/FileHelper.java" not found!
Inspection showed src/android/FileHelper.java doesn't exist, so I removed that line.
I also added the AssetFilesystem.java line for consistency with the android section, but don't know if it's needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masonicboom/cordova-plugin-file patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit 989ff131ffa3c8dd66ba367de2cc4ec4a24864e1
Author: masonicboom <ma...@users.noreply.github.com>
Date: 2015-04-26T04:29:02Z
fix install on amazon-fireos
I'm shooting in the dark, here, so someone knowledgable please check this.
I was previously getting this error:
Failed to install 'cordova-plugin-file':Error: Uh oh!
".../plugins/cordova-plugin-file/src/android/FileHelper.java" not found!
Inspection showed src/android/FileHelper.java doesn't exist, so I removed that line.
I also added the AssetFilesystem.java line for consistency with the android section, but don't know if it's needed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos
Posted by dennisexozet <gi...@git.apache.org>.
Github user dennisexozet commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/113#issuecomment-147766169
:+1:
Is there a chance that this fix will soon be part of the master-branch? I cannot understand, why this fix isn't merged for nearly six months.
Otherwise I'm forced to use a non-official fork of this plugin but that's not what I intend to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos
Posted by paulhovey <gi...@git.apache.org>.
Github user paulhovey commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/113#issuecomment-113907241
+1, I am getting the error that "...plugins\cordova-plugin-file\src\android\FileHelper.java not found!" when installing for amazon-fireos.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos
Posted by tomstgeorge <gi...@git.apache.org>.
Github user tomstgeorge commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/113#issuecomment-142695583
Trying again to get my app working on amazon-fireos. Using this fix I know get this when trying to build
```
[javac] /Library/MobileApps/testfire/platforms/amazon-fireos/src/org/apache/cordova/file/LocalFilesystem.java:414: error: cannot find symbol
[javac] if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
[javac] ^
[javac] symbol: variable LOLLIPOP
[javac] location: class VERSION_CODES
[javac] /Library/MobileApps/testfire/platforms/amazon-fireos/src/org/apache/cordova/file/LocalFilesystem.java:415: error: cannot find symbol
[javac] for (File f : context.getExternalMediaDirs()) {
[javac] ^
[javac] symbol: method getExternalMediaDirs()
[javac] location: variable context of type Context
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: fix install on amazon-fireos
Posted by tomstgeorge <gi...@git.apache.org>.
Github user tomstgeorge commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/113#issuecomment-131932324
Managed to add the plugin to amazon-fireos using this fix, however app won't build when using this plugin for amazon-fireos
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org