You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Junjie Peng (JIRA)" <ji...@apache.org> on 2008/07/07 09:49:31 UTC
[jira] Created: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
------------------------------------------------------------------------------------
Key: DERBY-3762
URL: https://issues.apache.org/jira/browse/DERBY-3762
Project: Derby
Issue Type: Test
Environment: windows xp, sp2.
Reporter: Junjie Peng
Assignee: Junjie Peng
Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng closed DERBY-3762.
------------------------------
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt, derby-3762-3-patch.txt, derby-3762-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren updated DERBY-3762:
--------------------------------------
Derby Info: (was: [Patch Available])
Fix Version/s: 10.5.0.0
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Fix For: 10.5.0.0
>
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt, derby-3762-3-patch.txt, derby-3762-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612731#action_12612731 ]
Junjie Peng commented on DERBY-3762:
------------------------------------
Good suggestion, it's useful to me, and I will take it in next patch. Thanks, Bryan!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613655#action_12613655 ]
Kathey Marsden commented on DERBY-3762:
---------------------------------------
Committed revision 676956.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt, derby-3762-3-patch.txt, derby-3762-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3762:
-------------------------------
Attachment: derby-3762-3-stat.txt
derby-3762-3-patch.txt
Rename private method beginning with "test" to "doXXX".
Please check it!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt, derby-3762-3-patch.txt, derby-3762-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3762:
----------------------------------
Component/s: Test
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt, derby-3762-3-patch.txt, derby-3762-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng resolved DERBY-3762.
--------------------------------
Resolution: Fixed
Derby Info: [Patch Available]
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt, derby-3762-3-patch.txt, derby-3762-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3762:
-------------------------------
Attachment: derby-3762-2-stat.txt
derby-3762-2-patch.txt
Add a change on java\testing\org\apache\derbyTesting\functionTests\tests\lang\LangScripts.java. Delete arithmetic.sql from it.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3762:
-------------------------------
Attachment: derby-3762-1-stat.txt
derby-3762-1-patch.txt
Please check the patch! Thank you!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-3762:
----------------------------------
Derby Info: (was: [Patch Available])
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt, derby-3762-3-patch.txt, derby-3762-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3762) Convert
"org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612564#action_12612564 ]
Bryan Pendleton commented on DERBY-3762:
----------------------------------------
Thanks for the patch!
I noticed that there seem to be public methods named testXXX, and private
methods named testYYY, and the private methods appear to be 'helper'
functions for the public test case methods.
I think that's a bit confusing; I think it would be a bit clearer to use a different
naming convention for the private test methods to make it more obvious
that they are not test cases themselves, but rather are helper methods
for the other test cases.
Perhaps the private methods could be renamed from 'testYYY' to
'doYYY' or 'performYYY' or some similar naming convention to help
distinguish them.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3762
> URL: https://issues.apache.org/jira/browse/DERBY-3762
> Project: Derby
> Issue Type: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3762-1-patch.txt, derby-3762-1-stat.txt, derby-3762-2-patch.txt, derby-3762-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.arithmetic.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.