You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2017/09/28 04:49:33 UTC
[1/3] kudu git commit: master-test: deflake a test
Repository: kudu
Updated Branches:
refs/heads/master 9b0544ae3 -> 54aef924a
master-test: deflake a test
In this test the master would periodically crash in Restart due to an
injected SysCatalogTable::Write failure.
Change-Id: Ic6bd104f818b76a74f4b56353dc6f3839e1c02cc
Reviewed-on: http://gerrit.cloudera.org:8080/8158
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/aa52b05e
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/aa52b05e
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/aa52b05e
Branch: refs/heads/master
Commit: aa52b05e783f45ec8d04f61352216df56fa9e13e
Parents: 9b0544a
Author: Adar Dembo <ad...@cloudera.com>
Authored: Wed Sep 27 17:05:14 2017 -0700
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Thu Sep 28 04:49:03 2017 +0000
----------------------------------------------------------------------
src/kudu/master/master-test.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/aa52b05e/src/kudu/master/master-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/master-test.cc b/src/kudu/master/master-test.cc
index 499e9c2..5684eb9 100644
--- a/src/kudu/master/master-test.cc
+++ b/src/kudu/master/master-test.cc
@@ -1118,8 +1118,10 @@ TEST_F(MasterTest, TestMasterMetadataConsistentDespiteFailures) {
ASSERT_GE(num_injected_failures, 1);
// Restart the catalog manager to ensure that it can survive reloading the
- // metadata we wrote to disk.
+ // metadata we wrote to disk. Make sure failure injection is disabled as
+ // restarting may issue several catalog writes.
mini_master_->Shutdown();
+ FLAGS_sys_catalog_fail_during_write = 0.0;
ASSERT_OK(mini_master_->Restart());
// Reload the metadata again, this time verifying its consistency.
[2/3] kudu git commit: master-test: fix test-only TSAN data race
Posted by ad...@apache.org.
master-test: fix test-only TSAN data race
MasterTest.TestRegisterAndHeartbeat: WARNING: ThreadSanitizer: data race (pid=23366) Write of size 8 at 0x7b4c00000d60 by main thread:
#0 kudu::master::CatalogManager::ScopedLeaderDisablerForTests::ScopedLeaderDisablerForTests(kudu::master::CatalogManager*) /data/jenkins-workspace/kudu-workspace/src/kudu/master/catalog_manager.h:448:36 (master-test+0x50d9b7)
#1 kudu::master::MasterTest_TestRegisterAndHeartbeat_Test::TestBody() /data/jenkins-workspace/kudu-workspace/src/kudu/master/master-test.cc:238:50 (master-test+0x4f07b2)
#2 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x52ac9)
#3 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438 (libgmock.so+0x52ac9)
#4 testing::Test::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2474:5 (libgmock.so+0x32cb7)
#5 testing::TestInfo::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x34156)
#6 testing::TestCase::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x34ec6)
#7 testing::internal::UnitTestImpl::RunAllTests() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x40916)
#8 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x539a9)
#9 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438 (libgmock.so+0x539a9)
#10 testing::UnitTest::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x40361)
#11 RUN_ALL_TESTS() /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x338b)
#12 main /data/jenkins-workspace/kudu-workspace/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x2a46)
Previous read of size 8 at 0x7b4c00000d60 by thread T79 (mutexes: read M3335, write M3813):
#0 kudu::master::CatalogManager::ScopedLeaderSharedLock::ScopedLeaderSharedLock(kudu::master::CatalogManager*) /data/jenkins-workspace/kudu-workspace/src/kudu/master/catalog_manager.cc:4218:7 (libmaster.so+0xabc37)
#1 kudu::master::CatalogManagerBgTasks::Run() /data/jenkins-workspace/kudu-workspace/src/kudu/master/catalog_manager.cc:490:46 (libmaster.so+0x90e26)
#2 boost::_mfi::mf0<void, kudu::master::CatalogManagerBgTasks>::operator()(kudu::master::CatalogManagerBgTasks*) const /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/mem_fn_template.hpp:49:29 (libmaster.so+0xd4676)
#3 void boost::_bi::list1<boost::_bi::value<kudu::master::CatalogManagerBgTasks*> >::operator()<boost::_mfi::mf0<void, kudu::master::CatalogManagerBgTasks>, boost::_bi::list0>(boost::_bi::type<void>, boost::_mfi::mf0<void, kudu::master::CatalogManagerBgTasks>&, boost::_bi::list0&, int) /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/bind.hpp:259:9 (libmaster.so+0xd45ca)
#4 boost::_bi::bind_t<void, boost::_mfi::mf0<void, kudu::master::CatalogManagerBgTasks>, boost::_bi::list1<boost::_bi::value<kudu::master::CatalogManagerBgTasks*> > >::operator()() /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/bind.hpp:1222:16 (libmaster.so+0xd4553)
#5 boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void, boost::_mfi::mf0<void, kudu::master::CatalogManagerBgTasks>, boost::_bi::list1<boost::_bi::value<kudu::master::CatalogManagerBgTasks*> > >, void>::invoke(boost::detail::function::function_buffer&) /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/function/function_template.hpp:159:11 (libmaster.so+0xd4359)
#6 boost::function0<void>::operator()() const /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/function/function_template.hpp:770:14 (libkrpc.so+0xb5d81)
#7 kudu::Thread::SuperviseThread(void*) /data/jenkins-workspace/kudu-workspace/src/kudu/util/thread.cc:601:3 (libkudu_util.so+0x1b279e)
Location is heap block of size 408 at 0x7b4c00000c40 allocated by main thread:
#0 operator new(unsigned long) /data/jenkins-workspace/kudu-workspace/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:41 (master-test+0x4ec0d3)
#1 kudu::master::Master::Master(kudu::master::MasterOptions const&) /data/jenkins-workspace/kudu-workspace/src/kudu/master/master.cc:97:22 (libmaster.so+0xe306f)
#2 kudu::master::MiniMaster::Start() /data/jenkins-workspace/kudu-workspace/src/kudu/master/mini_master.cc:91:33 (libmaster.so+0xfeac9)
#3 kudu::master::MasterTest::SetUp() /data/jenkins-workspace/kudu-workspace/src/kudu/master/master-test.cc:108:5 (master-test+0x512c95)
#4 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x52ac9)
#5 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438 (libgmock.so+0x52ac9)
#6 testing::Test::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2470:3 (libgmock.so+0x32c46)
#7 testing::TestInfo::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x34156)
#8 testing::TestCase::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x34ec6)
#9 testing::internal::UnitTestImpl::RunAllTests() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x40916)
#10 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x539a9)
#11 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438 (libgmock.so+0x539a9)
#12 testing::UnitTest::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x40361)
#13 RUN_ALL_TESTS() /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x338b)
#14 main /data/jenkins-workspace/kudu-workspace/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x2a46)
Mutex M3335 (0x7b4c00000d68) created at:
#0 pthread_rwlock_init /data/jenkins-workspace/kudu-workspace/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:1205 (master-test+0x47e40c)
#1 kudu::RWMutex::Init(kudu::RWMutex::Priority) /data/jenkins-workspace/kudu-workspace/src/kudu/util/rw_mutex.cc:78:8 (libkudu_util.so+0x19ecc8)
#2 kudu::RWMutex::RWMutex(kudu::RWMutex::Priority) /data/jenkins-workspace/kudu-workspace/src/kudu/util/rw_mutex.cc:56:3 (libkudu_util.so+0x19ef23)
#3 kudu::master::CatalogManager::CatalogManager(kudu::master::Master*) /data/jenkins-workspace/kudu-workspace/src/kudu/master/catalog_manager.cc:733:5 (libmaster.so+0x92a4a)
#4 kudu::master::Master::Master(kudu::master::MasterOptions const&) /data/jenkins-workspace/kudu-workspace/src/kudu/master/master.cc:97:26 (libmaster.so+0xe307d)
#5 kudu::master::MiniMaster::Start() /data/jenkins-workspace/kudu-workspace/src/kudu/master/mini_master.cc:91:33 (libmaster.so+0xfeac9)
#6 kudu::master::MasterTest::SetUp() /data/jenkins-workspace/kudu-workspace/src/kudu/master/master-test.cc:108:5 (master-test+0x512c95)
#7 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x52ac9)
#8 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438 (libgmock.so+0x52ac9)
#9 testing::Test::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2470:3 (libgmock.so+0x32c46)
#10 testing::TestInfo::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2656:11 (libgmock.so+0x34156)
#11 testing::TestCase::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2774:28 (libgmock.so+0x34ec6)
#12 testing::internal::UnitTestImpl::RunAllTests() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4649:43 (libgmock.so+0x40916)
#13 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2402:10 (libgmock.so+0x539a9)
#14 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:2438 (libgmock.so+0x539a9)
#15 testing::UnitTest::Run() /data/jenkins-workspace/kudu-workspace/thirdparty/src/googletest-release-1.8.0/googletest/src/gtest.cc:4257:10 (libgmock.so+0x40361)
#16 RUN_ALL_TESTS() /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/gtest/gtest.h:2233:46 (libkudu_test_main.so+0x338b)
#17 main /data/jenkins-workspace/kudu-workspace/src/kudu/util/test_main.cc:106:13 (libkudu_test_main.so+0x2a46)
Mutex M3813 (0x7b4c00000d50) created at:
#0 __tsan_atomic32_compare_exchange_strong /data/jenkins-workspace/kudu-workspace/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cc:756 (master-test+0x4a8d08)
#1 base::subtle::Acquire_CompareAndSwap(int volatile*, int, int) /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/atomicops-internals-tsan.h:84:3 (libkudu_client.so+0xb4087)
#2 base::SpinLock::Lock() /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/spinlock.h:74:9 (libkudu_client.so+0xb3ff0)
#3 kudu::simple_spinlock::lock() /data/jenkins-workspace/kudu-workspace/src/kudu/util/locks.h:44:8 (libkudu_client.so+0xb3fa9)
#4 std::__1::lock_guard<kudu::simple_spinlock>::lock_guard(kudu::simple_spinlock&) /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/c++/v1/__mutex_base:108:27 (libmaster.so+0x96321)
#5 kudu::master::CatalogManager::IsInitialized() const /data/jenkins-workspace/kudu-workspace/src/kudu/master/catalog_manager.cc:1134 (libmaster.so+0x96321)
#6 kudu::master::Master::InitCatalogManager() /data/jenkins-workspace/kudu-workspace/src/kudu/master/master.cc:186:25 (libmaster.so+0xe47e2)
#7 kudu::master::Master::InitCatalogManagerTask() /data/jenkins-workspace/kudu-workspace/src/kudu/master/master.cc:178:14 (libmaster.so+0xe4692)
#8 kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>::Run(kudu::master::Master*) /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/bind_internal.h:136:12 (libmaster.so+0xe8876)
#9 kudu::internal::InvokeHelper<false, void, kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>, void ()(kudu::master::Master*)>::MakeItSo(kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>, kudu::master::Master*) /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/bind_internal.h:873:14 (libmaster.so+0xe8795)
#10 kudu::internal::Invoker<1, kudu::internal::BindState<kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>, void ()(kudu::master::Master*), void ()(kudu::internal::UnretainedWrapper<kudu::master::Master>)>, void ()(kudu::master::Master*)>::Run(kudu::internal::BindStateBase*) /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/bind_internal.h:1065:12 (libmaster.so+0xe86da)
#11 kudu::Callback<void ()()>::Run() const /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/callback.h:396:12 (libconsensus.so+0x9259d)
#12 kudu::ClosureRunnable::Run() /data/jenkins-workspace/kudu-workspace/src/kudu/util/threadpool.cc:74:9 (libkudu_util.so+0x1be53d)
#13 kudu::ThreadPool::DispatchThread(bool) /data/jenkins-workspace/kudu-workspace/src/kudu/util/threadpool.cc:631:22 (libkudu_util.so+0x1bb871)
#14 boost::_mfi::mf1<void, kudu::ThreadPool, bool>::operator()(kudu::ThreadPool*, bool) const /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/mem_fn_template.hpp:165:29 (libkudu_util.so+0x1c412e)
#15 void boost::_bi::list2<boost::_bi::value<kudu::ThreadPool*>, boost::_bi::value<bool> >::operator()<boost::_mfi::mf1<void, kudu::ThreadPool, bool>, boost::_bi::list0>(boost::_bi::type<void>, boost::_mfi::mf1<void, kudu::ThreadPool, bool>&, boost::_bi::list0&, int) /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/bind.hpp:319:9 (libkudu_util.so+0x1c406d)
#16 boost::_bi::bind_t<void, boost::_mfi::mf1<void, kudu::ThreadPool, bool>, boost::_bi::list2<boost::_bi::value<kudu::ThreadPool*>, boost::_bi::value<bool> > >::operator()() /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/bind.hpp:1222:16 (libkudu_util.so+0x1c3fd3)
#17 boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void, boost::_mfi::mf1<void, kudu::ThreadPool, bool>, boost::_bi::list2<boost::_bi::value<kudu::ThreadPool*>, boost::_bi::value<bool> > >, void>::invoke(boost::detail::function::function_buffer&) /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/function/function_template.hpp:159:11 (libkudu_util.so+0x1c3d71)
#18 boost::function0<void>::operator()() const /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/function/function_template.hpp:770:14 (libkrpc.so+0xb5d81)
#19 kudu::Thread::SuperviseThread(void*) /data/jenkins-workspace/kudu-workspace/src/kudu/util/thread.cc:601:3 (libkudu_util.so+0x1b279e)
Thread T79 'bgtasks-24777' (tid=24777, running) created by thread T47 at:
#0 pthread_create /data/jenkins-workspace/kudu-workspace/thirdparty/src/llvm-4.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:897 (master-test+0x47fd4b)
#1 kudu::Thread::StartThread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, boost::function<void ()()> const&, unsigned long, scoped_refptr<kudu::Thread>*) /data/jenkins-workspace/kudu-workspace/src/kudu/util/thread.cc:524:15 (libkudu_util.so+0x1b1f97)
#2 kudu::Status kudu::Thread::Create<void (kudu::master::CatalogManagerBgTasks::*)(), kudu::master::CatalogManagerBgTasks*>(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, void (kudu::master::CatalogManagerBgTasks::* const&)(), kudu::master::CatalogManagerBgTasks* const&, scoped_refptr<kudu::Thread>*) /data/jenkins-workspace/kudu-workspace/src/kudu/util/thread.h:165:12 (libmaster.so+0xafcb5)
#3 kudu::master::CatalogManagerBgTasks::Init() /data/jenkins-workspace/kudu-workspace/src/kudu/master/catalog_manager.cc:470:3 (libmaster.so+0x90cff)
#4 kudu::master::CatalogManager::Init(bool) /data/jenkins-workspace/kudu-workspace/src/kudu/master/catalog_manager.cc:766:3 (libmaster.so+0x931de)
#5 kudu::master::Master::InitCatalogManager() /data/jenkins-workspace/kudu-workspace/src/kudu/master/master.cc:189:3 (libmaster.so+0xe483f)
#6 kudu::master::Master::InitCatalogManagerTask() /data/jenkins-workspace/kudu-workspace/src/kudu/master/master.cc:178:14 (libmaster.so+0xe4692)
#7 kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>::Run(kudu::master::Master*) /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/bind_internal.h:136:12 (libmaster.so+0xe8876)
#8 kudu::internal::InvokeHelper<false, void, kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>, void ()(kudu::master::Master*)>::MakeItSo(kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>, kudu::master::Master*) /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/bind_internal.h:873:14 (libmaster.so+0xe8795)
#9 kudu::internal::Invoker<1, kudu::internal::BindState<kudu::internal::RunnableAdapter<void (kudu::master::Master::*)()>, void ()(kudu::master::Master*), void ()(kudu::internal::UnretainedWrapper<kudu::master::Master>)>, void ()(kudu::master::Master*)>::Run(kudu::internal::BindStateBase*) /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/bind_internal.h:1065:12 (libmaster.so+0xe86da)
#10 kudu::Callback<void ()()>::Run() const /data/jenkins-workspace/kudu-workspace/src/kudu/gutil/callback.h:396:12 (libconsensus.so+0x9259d)
#11 kudu::ClosureRunnable::Run() /data/jenkins-workspace/kudu-workspace/src/kudu/util/threadpool.cc:74:9 (libkudu_util.so+0x1be53d)
#12 kudu::ThreadPool::DispatchThread(bool) /data/jenkins-workspace/kudu-workspace/src/kudu/util/threadpool.cc:631:22 (libkudu_util.so+0x1bb871)
#13 boost::_mfi::mf1<void, kudu::ThreadPool, bool>::operator()(kudu::ThreadPool*, bool) const /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/mem_fn_template.hpp:165:29 (libkudu_util.so+0x1c412e)
#14 void boost::_bi::list2<boost::_bi::value<kudu::ThreadPool*>, boost::_bi::value<bool> >::operator()<boost::_mfi::mf1<void, kudu::ThreadPool, bool>, boost::_bi::list0>(boost::_bi::type<void>, boost::_mfi::mf1<void, kudu::ThreadPool, bool>&, boost::_bi::list0&, int) /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/bind.hpp:319:9 (libkudu_util.so+0x1c406d)
#15 boost::_bi::bind_t<void, boost::_mfi::mf1<void, kudu::ThreadPool, bool>, boost::_bi::list2<boost::_bi::value<kudu::ThreadPool*>, boost::_bi::value<bool> > >::operator()() /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/bind/bind.hpp:1222:16 (libkudu_util.so+0x1c3fd3)
#16 boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void, boost::_mfi::mf1<void, kudu::ThreadPool, bool>, boost::_bi::list2<boost::_bi::value<kudu::ThreadPool*>, boost::_bi::value<bool> > >, void>::invoke(boost::detail::function::function_buffer&) /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/function/function_template.hpp:159:11 (libkudu_util.so+0x1c3d71)
#17 boost::function0<void>::operator()() const /data/jenkins-workspace/kudu-workspace/thirdparty/installed/tsan/include/boost/function/function_template.hpp:770:14 (libkrpc.so+0xb5d81)
#18 kudu::Thread::SuperviseThread(void*) /data/jenkins-workspace/kudu-workspace/src/kudu/util/thread.cc:601:3 (libkudu_util.so+0x1b279e)
Change-Id: I8f0363eb963e55a9ecf02bb68616e2925d8cc6cc
Reviewed-on: http://gerrit.cloudera.org:8080/8159
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/37571b19
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/37571b19
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/37571b19
Branch: refs/heads/master
Commit: 37571b19952958320be2518ddbe1a35cf266cca4
Parents: aa52b05
Author: Adar Dembo <ad...@cloudera.com>
Authored: Wed Sep 27 17:06:04 2017 -0700
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Thu Sep 28 04:49:07 2017 +0000
----------------------------------------------------------------------
src/kudu/master/catalog_manager.h | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/37571b19/src/kudu/master/catalog_manager.h
----------------------------------------------------------------------
diff --git a/src/kudu/master/catalog_manager.h b/src/kudu/master/catalog_manager.h
index 1f7dd91..e2644ce 100644
--- a/src/kudu/master/catalog_manager.h
+++ b/src/kudu/master/catalog_manager.h
@@ -445,10 +445,12 @@ class CatalogManager : public tserver::TabletReplicaLookupIf {
explicit ScopedLeaderDisablerForTests(CatalogManager* catalog)
: catalog_(catalog),
old_leader_ready_term_(catalog->leader_ready_term_) {
+ std::lock_guard<simple_spinlock> l(catalog_->state_lock_);
catalog_->leader_ready_term_ = -1;
}
~ScopedLeaderDisablerForTests() {
+ std::lock_guard<simple_spinlock> l(catalog_->state_lock_);
catalog_->leader_ready_term_ = old_leader_ready_term_;
}
[3/3] kudu git commit: master-test: fix another source of test
flakiness
Posted by ad...@apache.org.
master-test: fix another source of test flakiness
This timeout is behind one failure on the flaky test dashboard:
/data/jenkins-workspace/kudu-workspace/src/kudu/master/master-test.cc:110: Failure
Failed
Bad status: Timed out: Maximum time exceeded waiting for master leadership: OK
Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
Reviewed-on: http://gerrit.cloudera.org:8080/8160
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/54aef924
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/54aef924
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/54aef924
Branch: refs/heads/master
Commit: 54aef924a4fab41d1fc939a479894ecd561b8d43
Parents: 37571b1
Author: Adar Dembo <ad...@cloudera.com>
Authored: Wed Sep 27 17:08:26 2017 -0700
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Thu Sep 28 04:49:09 2017 +0000
----------------------------------------------------------------------
src/kudu/master/master-test.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/54aef924/src/kudu/master/master-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/master-test.cc b/src/kudu/master/master-test.cc
index 5684eb9..dc5da9a 100644
--- a/src/kudu/master/master-test.cc
+++ b/src/kudu/master/master-test.cc
@@ -107,7 +107,8 @@ class MasterTest : public KuduTest {
mini_master_.reset(new MiniMaster(GetTestPath("Master"), HostPort("127.0.0.1", 0)));
ASSERT_OK(mini_master_->Start());
master_ = mini_master_->master();
- ASSERT_OK(master_->WaitUntilCatalogManagerIsLeaderAndReadyForTests(MonoDelta::FromSeconds(5)));
+ ASSERT_OK(master_->WaitUntilCatalogManagerIsLeaderAndReadyForTests(
+ MonoDelta::FromSeconds(90)));
// Create a client proxy to it.
MessengerBuilder bld("Client");