You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fantonangeli (via GitHub)" <gi...@apache.org> on 2025/04/30 15:26:55 UTC
[PR] [NO-ISSUE] Patternfly v5 upgrade onChange events fixes [incubator-kie-tools]
fantonangeli opened a new pull request, #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095
This PR fixes some onChange events that are not passing the value to the callback.
I suggest merging on `main` after https://github.com/apache/incubator-kie-tools/pull/3089 not to block the main PR.
cc @kumaradityaraj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Patternfly v5 upgrade onChange events fixes [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095#discussion_r2069096567
##########
packages/jbpm-quarkus-devui/dev/src/main/resources/custom-forms-dev/hiring.tsx:
##########
@@ -69,7 +69,7 @@ const Form__hiring: React.FC<any> = (props: any) => {
placeholder={""}
type={"text"}
value={candidate}
- onChange={set__candidate}
Review Comment:
The idea is not to fix it later but to fix it now in a different PR pointing to main to unblock the original pf5 upgrade PR, just like what this PR is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Patternfly v5 upgrade onChange events fixes [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095#discussion_r2068929627
##########
packages/jbpm-quarkus-devui/dev/src/main/resources/custom-forms-dev/hiring.tsx:
##########
@@ -69,7 +69,7 @@ const Form__hiring: React.FC<any> = (props: any) => {
placeholder={""}
type={"text"}
value={candidate}
- onChange={set__candidate}
Review Comment:
@ljmotta I think we need to review the form generation code to avoid cases like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Patternfly v5 upgrade onChange events fixes [incubator-kie-tools]
Posted by "ljmotta (via GitHub)" <gi...@apache.org>.
ljmotta commented on code in PR #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095#discussion_r2069067263
##########
packages/jbpm-quarkus-devui/dev/src/main/resources/custom-forms-dev/hiring.tsx:
##########
@@ -69,7 +69,7 @@ const Form__hiring: React.FC<any> = (props: any) => {
placeholder={""}
type={"text"}
value={candidate}
- onChange={set__candidate}
Review Comment:
I don't think is a good idea to break the feature to fix it latter. I'll try to provide a quick fix for it, and open a PR to the patternfly branch. I'll just need to double check all components used in the `form-code-generator-patternfly-theme` package. Like Select, Checkbox, Radio, DatePicker, TimePicker, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Patternfly v5 upgrade onChange events fixes [incubator-kie-tools]
Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on code in PR #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095#discussion_r2069312229
##########
packages/jbpm-quarkus-devui/dev/src/main/resources/custom-forms-dev/hiring.tsx:
##########
@@ -69,7 +69,7 @@ const Form__hiring: React.FC<any> = (props: any) => {
placeholder={""}
type={"text"}
value={candidate}
- onChange={set__candidate}
Review Comment:
+1 @thiagoelg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Patternfly v5 upgrade onChange events fixes [incubator-kie-tools]
Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on code in PR #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095#discussion_r2068945993
##########
packages/jbpm-quarkus-devui/dev/src/main/resources/custom-forms-dev/hiring.tsx:
##########
@@ -69,7 +69,7 @@ const Form__hiring: React.FC<any> = (props: any) => {
placeholder={""}
type={"text"}
value={candidate}
- onChange={set__candidate}
Review Comment:
@ljmotta @thiagoelg Maybe we can create an issue in this epic for this?
https://github.com/apache/incubator-kie-issues/issues/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] `onChange` events fixes after PatternFly v5 upgrade [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE] Patternfly v5 upgrade onChange events fixes [incubator-kie-tools]
Posted by "fantonangeli (via GitHub)" <gi...@apache.org>.
fantonangeli commented on code in PR #3095:
URL: https://github.com/apache/incubator-kie-tools/pull/3095#discussion_r2068945993
##########
packages/jbpm-quarkus-devui/dev/src/main/resources/custom-forms-dev/hiring.tsx:
##########
@@ -69,7 +69,7 @@ const Form__hiring: React.FC<any> = (props: any) => {
placeholder={""}
type={"text"}
value={candidate}
- onChange={set__candidate}
Review Comment:
Maybe we can create an issue in this epic for this?
https://github.com/apache/incubator-kie-issues/issues/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org