[jira] [Commented] (AMQ-5378) Initscript refactoring: setup function seems to be broken, removal of uneccessary files, fix various problems

["Dejan Bosanac (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229917#comment-14229917 ] 

Dejan Bosanac commented on AMQ-5378:
------------------------------------

Hi Marc,

I'm for simplifying the current script as much as we can. In all these years, I haven't seen anyone using setup function, so that's why it got broken. By moving default configuration in a separate script (we can call it activemqrc or something) we will make life easier for 99.99% of the users. And it will be easy to achieve what "setup" does by simply copying the file to the appropriate place. So we can remove that option from the script (while maintaining the functionality) and document everything properly (we don't need to have all this in the script help). By doing this we will make the script much simpler, easier to use and maintain. Also, we will get in-line with other Apache projects, like Karaf that are using the similar approach.

On other notes:
- bstat never checked if broker is running, so it's not a regression, but it's a nice improvement we should add
- create, encrypt and decrypt are working fine without broker running 

I hope you're willing to help with these tasks.

Wiki is located at https://cwiki.apache.org/confluence/

> Initscript refactoring: setup function seems to be broken, removal of uneccessary files, fix various problems
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-5378
>                 URL: https://issues.apache.org/jira/browse/AMQ-5378
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.10.0
>         Environment: Linux/Unix
>            Reporter: Marc Schöchlin
>              Labels: assemblies
>             Fix For: 5.11.0
>
>         Attachments: AMQ-5378.patch
>
>
> The current initscript seems to be broken.
> I submitted the current unix init script (see AMQ-2453) - the original script seems to be modified in a way which breaks the "setup" function
> If you call "./activemq setup ~/.activemq" you get a really messy configfile.
> The current distribution also contains lots of files of the java service wrapper which are not needed anymore.
> I created the following patch/pull request:
> https://github.com/apache/activemq/pull/46



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)