[jira] Commented: (HIVEMIND-82) Exception handling needs to allow RuntimeExceptions through rather than wrapping them yet again

["James Carman (JIRA)" <hi...@jakarta.apache.org>]

     [ http://issues.apache.org/jira/browse/HIVEMIND-82?page=comments#action_64479 ]
     
James Carman commented on HIVEMIND-82:
--------------------------------------

What about this one, guys?  What do we want to do with this?

> Exception handling needs to allow RuntimeExceptions through rather than wrapping them yet again
> -----------------------------------------------------------------------------------------------
>
>          Key: HIVEMIND-82
>          URL: http://issues.apache.org/jira/browse/HIVEMIND-82
>      Project: HiveMind
>         Type: Improvement
>   Components: framework
>     Versions: 1.0, 1.1
>     Reporter: Hal Hildebrand
>     Priority: Minor

>
> There's a lot of creation of ApplicationRuntimeExceptions, a RuntimeException, in the framework.  There are also quite a number of error handlers for Exception which wrap the Exception in an ApplicationRuntimeException.  All of these error handlers should have another handler for RuntimeException which allows these exceptions to blow through without wrapping.
> for example, instead of:
> try {
> } catch (Exception e) {
>   throw new ApplicationRuntimeException(UtilMessages.invokeFailed(c, ex), null, ex);
> }
> this should be:
> try {
> } catch (RuntimeException e) {
>   throw e;
> } catch (Exception e) {
>   throw new ApplicationRuntimeException(UtilMessages.invokeFailed(c, ex), null, ex);
> }
> This significantly cuts down on the redundant wrapping of ApplicationRuntimeExceptions.  These redundant wrappings just make for HUGE stack traces which obscure where the problem really is.  It also looks really ugly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: hivemind-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: hivemind-dev-help@jakarta.apache.org