[GitHub] [ozone] sodonnel commented on a change in pull request #3008: HDDS-6131: EC: Replication config from bucket should be refreshed in o3fs

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #3008:
URL: https://github.com/apache/ozone/pull/3008#discussion_r791736925



##########
File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientUtils.java
##########
@@ -64,4 +73,78 @@ public static BucketLayout resolveLinkBucketLayout(OzoneBucket bucket,
     }
     return bucket.getBucketLayout();
   }
+
+  /**
+   * This API used to resolve the client side configuration preference for file
+   * system layer implementations.
+   *
+   * @param replication                - replication value passed from FS API.
+   * @param clientConfiguredReplConfig - Client side configured replication
+   *                                   config.
+   * @param bucketReplConfig           - server side bucket default replication
+   *                                  config.
+   * @param config                     - Ozone configuration object.
+   * @return client resolved replication config.
+   */
+  public static ReplicationConfig resolveClientSideReplicationConfig(

Review comment:
       Should we add a unit test for this logic? There is a fair bit going on here to not have a test covering it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org