[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2266: IGNITE-19778 Restore components state on metastorage recovery

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #2266:
URL: https://github.com/apache/ignite-3/pull/2266#discussion_r1251881826


##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java:
##########
@@ -296,9 +268,9 @@ public CompletableFuture<Boolean> write(Map<String, ? extends Serializable> newV
 
         operations.add(Operations.put(MASTER_KEY, ByteUtils.longToBytes(curChangeId)));
 
-        SimpleCondition condition = curChangeId == 0L
-                ? Conditions.notExists(MASTER_KEY)
-                : Conditions.revision(MASTER_KEY).eq(curChangeId);
+        Condition condition = curChangeId == 0L
+                ? notExists(MASTER_KEY)
+                : or(notExists(MASTER_KEY), revision(MASTER_KEY).le(curChangeId));

Review Comment:
   You forgot to return the old comment back, please do it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org