You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/24 05:59:54 UTC

[GitHub] [flink] deadwind4 opened a new pull request, #19802: [FLINK-25188][python][build] Support m1 chip

deadwind4 opened a new pull request, #19802:
URL: https://github.com/apache/flink/pull/19802

   ## What is the purpose of the change
   
   Support m1 chip in PyFlink
   
   ## Brief change log
   
     - *Update python 3.7 3.8 dependencies: numpy>= 1.21.4, pyarrow>=5.0.0, pandas>=1.3.0, apache-beam==2.38.0, cloudpickle==2.0.0, pemja== 0.1.5*
     - *Fix Beam API to adapt 2.38.0 version*
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] deadwind4 commented on a diff in pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
deadwind4 commented on code in PR #19802:
URL: https://github.com/apache/flink/pull/19802#discussion_r887445060


##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -174,7 +174,7 @@ Mode "embedded" (default) submits Flink jobs from the local machine.
                                                --pyExecutable
                                                /usr/local/bin/python3). The python
                                                UDF worker depends on Python 3.6+,
-                                               Apache Beam (version == 2.27.0), Pip
+                                               Apache Beam (version == 2.38.0), Pip

Review Comment:
   Should I also add `pip>=20.3` into `dev-requirements.txt` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] deadwind4 commented on pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
deadwind4 commented on PR #19802:
URL: https://github.com/apache/flink/pull/19802#issuecomment-1139338885

   @maver1ck It's maybe a deserialization error, I am researching it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] deadwind4 commented on pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
deadwind4 commented on PR #19802:
URL: https://github.com/apache/flink/pull/19802#issuecomment-1141790781

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] maver1ck commented on pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
maver1ck commented on PR #19802:
URL: https://github.com/apache/flink/pull/19802#issuecomment-1141998964

   Success :) Good work @deadwind4 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] HuangXingBo commented on a diff in pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on code in PR #19802:
URL: https://github.com/apache/flink/pull/19802#discussion_r887437213


##########
docs/content/docs/dev/table/sqlClient.md:
##########
@@ -174,7 +174,7 @@ Mode "embedded" (default) submits Flink jobs from the local machine.
                                                --pyExecutable
                                                /usr/local/bin/python3). The python
                                                UDF worker depends on Python 3.6+,
-                                               Apache Beam (version == 2.27.0), Pip
+                                               Apache Beam (version == 2.38.0), Pip

Review Comment:
   Does the version of pip need to be changed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] deadwind4 commented on pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
deadwind4 commented on PR #19802:
URL: https://github.com/apache/flink/pull/19802#issuecomment-1142278758

   I need to make the CI auto-install different dev-requirements.txt in the python 3.6 version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19802:
URL: https://github.com/apache/flink/pull/19802#issuecomment-1135446849

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c13f232c4213998b4888ee9ec40967efc2c26ba2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c13f232c4213998b4888ee9ec40967efc2c26ba2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c13f232c4213998b4888ee9ec40967efc2c26ba2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] HuangXingBo closed pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
HuangXingBo closed pull request #19802: [FLINK-25188][python][build] Support m1 chip
URL: https://github.com/apache/flink/pull/19802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] maver1ck commented on a diff in pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
maver1ck commented on code in PR #19802:
URL: https://github.com/apache/flink/pull/19802#discussion_r885510753


##########
flink-python/README.md:
##########
@@ -26,7 +26,7 @@ The auto-generated Python docs can be found at [https://nightlies.apache.org/fli
 
 ## Python Requirements
 
-Apache Flink Python API depends on Py4J (currently version 0.10.9.3), CloudPickle (currently version 1.2.2), python-dateutil(currently version 2.8.0), Apache Beam (currently version 2.27.0).
+Apache Flink Python API depends on Py4J (currently version 0.10.9.3), CloudPickle (currently version 2.0.0), python-dateutil(currently version 2.8.0), Apache Beam (currently version 2.38.0).

Review Comment:
   Version 2.1.0 ?



##########
NOTICE:
##########
@@ -17,7 +17,7 @@ See bundled license files for details.
 This project bundles the following dependencies under the BSD license.
 See bundled license files for details.
 
-- cloudpickle:1.2.2
+- cloudpickle:2.0.0

Review Comment:
   Version 2.1.0 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] maver1ck commented on pull request #19802: [FLINK-25188][python][build] Support m1 chip

Posted by GitBox <gi...@apache.org>.
maver1ck commented on PR #19802:
URL: https://github.com/apache/flink/pull/19802#issuecomment-1138532243

   @deadwind4 Do you know why Azure job failed ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org