You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/02/04 14:28:03 UTC
svn commit: r1781673 - in /jmeter/trunk:
src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
xdocs/changes.xml
Author: pmouawad
Date: Sat Feb 4 14:28:03 2017
New Revision: 1781673
URL: http://svn.apache.org/viewvc?rev=1781673&view=rev
Log:
Bug 60689 - "httpclient4.validate_after_inactivity" has no impact leading to usage of potentially stale/closed connections
Bugzilla Id: 60689
Modified:
jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java?rev=1781673&r1=1781672&r2=1781673&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java Sat Feb 4 14:28:03 2017
@@ -106,7 +106,16 @@ public class JMeterPoolingClientConnecti
this.schemeRegistry = schemeRegistry;
this.dnsResolver = dnsResolver;
this.operator = createConnectionOperator(schemeRegistry);
- this.pool = new HttpConnPool(this.log, this.operator, 2, 20, timeToLive, tunit);
+ this.pool = new HttpConnPool(this.log, this.operator, 2, 20, timeToLive, tunit) {
+ /**
+ * @see org.apache.http.pool.AbstractConnPool#validate(org.apache.http.pool.PoolEntry)
+ */
+ @Override
+ protected boolean validate(HttpPoolEntry entry) {
+ return !entry.getConnection().isStale();
+ }
+
+ };
pool.setValidateAfterInactivity(validateAfterInactivity);
}
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1781673&r1=1781672&r2=1781673&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Feb 4 14:28:03 2017
@@ -204,6 +204,7 @@ JMeter now requires Java 8. Ensure you u
<li><bug>60575</bug>HTTP GET Requests could have a content-type header without a body.</li>
<li><bug>60643</bug>HTTP(S) Test Script Recorder doesn't correctly handle restart or start after stop. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
<li><bug>60652</bug>PUT might leak file descriptors.</li>
+ <li><bug>60689</bug><code>httpclient4.validate_after_inactivity</code> has no impact leading to usage of potentially stale/closed connections</li>
</ul>
<h3>Other Samplers</h3>