You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/08/11 12:49:39 UTC

[GitHub] [kylin] hit-lacus commented on a change in pull request #1352: KYLIN-4516 support System cube

hit-lacus commented on a change in pull request #1352:
URL: https://github.com/apache/kylin/pull/1352#discussion_r468553621



##########
File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -255,11 +255,13 @@ private ExecuteResult runSparkSubmit(KylinConfig config, String hadoopConf, Stri
 
             CliCommandExecutor exec = new CliCommandExecutor();
             Pair<Integer, String> result = exec.execute(cmd, patternedLogger, jobId);
+            updateMetaAfterBuilding(config);
+            //Add metrics information to execute result for JobMetricsFacade

Review comment:
       In which way do you "Add metrics information to execute result for JobMetricsFacade" ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org