You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Tim Van Steenburgh <va...@users.sf.net> on 2013/12/03 19:34:53 UTC
[allura:tickets] #6941 Create activity events for commits
---
** [tickets:#6941] Create activity events for commits**
**Status:** open
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Tue Dec 03, 2013 06:34 PM UTC
**Owner:** nobody
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Dave Brondsema <br...@users.sf.net>.
- **Size**: --> 1
---
** [tickets:#6941] Create activity events for commits**
**Status:** open
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Tue Dec 03, 2013 06:34 PM UTC
**Owner:** nobody
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Tim Van Steenburgh <va...@users.sf.net>.
- **status**: in-progress --> code-review
---
** [tickets:#6941] Create activity events for commits**
**Status:** code-review
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Tue Dec 03, 2013 09:50 PM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> in-progress
- **QA**: Dave Brondsema
---
** [tickets:#6941] Create activity events for commits**
**Status:** in-progress
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Wed Dec 04, 2013 01:06 AM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Dave Brondsema <br...@users.sf.net>.
`has_activity_access` should do a permission check on the tool
---
** [tickets:#6941] Create activity events for commits**
**Status:** in-progress
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Wed Dec 04, 2013 01:06 AM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Tim Van Steenburgh <va...@users.sf.net>.
Force-pushed a fix.
---
** [tickets:#6941] Create activity events for commits**
**Status:** code-review
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Wed Dec 04, 2013 08:17 PM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Tim Van Steenburgh <va...@users.sf.net>.
- **status**: in-progress --> code-review
---
** [tickets:#6941] Create activity events for commits**
**Status:** code-review
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Wed Dec 04, 2013 08:17 PM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Tim Van Steenburgh <va...@users.sf.net>.
tv/6941
Example here: https://sf-tvansteenburgh-1020.sb.sf.net/p/testactivity/activity/
No automated tests since I couldn't find any tests for `refresh_repo()`.
To test manually, make sure activitystream is enabled in ini, create new project, create repo, commit to it, view project activity page.
Obviously this will be more useful with detail like the commit message included. Will add that with [#6829].
---
** [tickets:#6941] Create activity events for commits**
**Status:** code-review
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Tue Dec 03, 2013 09:50 PM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Tim Van Steenburgh <va...@users.sf.net>.
- **status**: open --> in-progress
- **assigned_to**: Tim Van Steenburgh
---
** [tickets:#6941] Create activity events for commits**
**Status:** in-progress
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Tue Dec 03, 2013 06:53 PM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Dave Brondsema <br...@users.sf.net>.
Looks good. Just making a small tweak to simplify logic:
~~~~
::diff
- if app_config:
- project = Project.query.get(_id=app_config.project_id)
- app = app_config.load()(project, app_config)
- return has_access(app, perm, user, project)
+ return has_access(app_config, perm, user)
~~~~
This works since app_config.project automatically loads via app_config.project_id. And has_access checks for None and also loads the project via the first param.
---
** [tickets:#6941] Create activity events for commits**
**Status:** closed
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Thu Dec 05, 2013 10:17 PM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #6941 Create activity events for commits
Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> closed
---
** [tickets:#6941] Create activity events for commits**
**Status:** closed
**Labels:** activitystreams
**Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh
**Last Updated:** Thu Dec 05, 2013 10:17 PM UTC
**Owner:** Tim Van Steenburgh
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.