You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "bobhan1 (via GitHub)" <gi...@apache.org> on 2024/09/04 12:06:18 UTC

[PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

bobhan1 opened a new pull request, #40382:
URL: https://github.com/apache/doris/pull/40382

   picks https://github.com/apache/doris/pull/40322
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328877449

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 49473 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 784674ff3d9fc0972862338d505af3a63a340838, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17740	4340	4351	4340
   q2	2058	156	143	143
   q3	10441	1893	1949	1893
   q4	10340	1237	1315	1237
   q5	8452	3842	3950	3842
   q6	229	123	123	123
   q7	2016	1658	1607	1607
   q8	9279	2732	2709	2709
   q9	10009	9939	9657	9657
   q10	8769	3567	3565	3565
   q11	406	252	252	252
   q12	465	301	295	295
   q13	18329	3961	4105	3961
   q14	351	325	330	325
   q15	510	463	467	463
   q16	536	464	475	464
   q17	1136	980	966	966
   q18	7779	7283	7324	7283
   q19	2908	1470	1470	1470
   q20	1621	322	337	322
   q21	4649	4222	4152	4152
   q22	502	404	412	404
   Total cold run time: 118525 ms
   Total hot run time: 49473 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4367	4303	4283	4283
   q2	315	231	223	223
   q3	4159	4165	4109	4109
   q4	2759	2753	2740	2740
   q5	7089	7096	7099	7096
   q6	235	115	119	115
   q7	3234	2803	2819	2803
   q8	4364	4497	4472	4472
   q9	13719	13529	13519	13519
   q10	4220	4222	4243	4222
   q11	763	665	693	665
   q12	1016	844	845	844
   q13	6793	3747	3730	3730
   q14	466	433	412	412
   q15	510	463	459	459
   q16	643	599	587	587
   q17	3823	3900	3821	3821
   q18	8683	8783	8702	8702
   q19	1718	1647	1672	1647
   q20	2356	2143	2138	2138
   q21	8603	8445	8420	8420
   q22	1022	956	947	947
   Total cold run time: 80857 ms
   Total hot run time: 75954 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328794843

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328949031

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.57 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 784674ff3d9fc0972862338d505af3a63a340838, data reload: false
   
   query1	0.02	0.02	0.02
   query2	0.08	0.02	0.02
   query3	0.25	0.04	0.04
   query4	1.80	0.06	0.06
   query5	0.55	0.52	0.52
   query6	1.29	0.61	0.61
   query7	0.01	0.01	0.01
   query8	0.04	0.03	0.02
   query9	0.50	0.49	0.47
   query10	0.54	0.55	0.53
   query11	0.12	0.08	0.08
   query12	0.11	0.08	0.09
   query13	0.62	0.61	0.62
   query14	0.78	0.78	0.79
   query15	0.80	0.76	0.77
   query16	0.36	0.37	0.37
   query17	1.00	1.03	1.00
   query18	0.20	0.26	0.24
   query19	1.88	1.84	1.79
   query20	0.01	0.01	0.02
   query21	15.49	0.56	0.56
   query22	2.04	2.29	1.61
   query23	17.02	1.15	0.99
   query24	6.75	0.80	1.54
   query25	0.33	0.13	0.05
   query26	0.71	0.16	0.16
   query27	0.04	0.03	0.04
   query28	6.35	0.73	0.74
   query29	12.63	2.40	2.33
   query30	0.58	0.52	0.53
   query31	2.81	0.38	0.37
   query32	3.40	0.50	0.49
   query33	3.07	3.06	3.06
   query34	15.26	4.78	4.76
   query35	4.84	4.84	4.84
   query36	1.06	1.01	1.01
   query37	0.06	0.05	0.04
   query38	0.04	0.02	0.02
   query39	0.02	0.02	0.01
   query40	0.17	0.14	0.15
   query41	0.07	0.01	0.02
   query42	0.02	0.01	0.02
   query43	0.03	0.02	0.01
   Total cold run time: 103.75 s
   Total hot run time: 30.57 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328795007

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "bobhan1 (via GitHub)" <gi...@apache.org>.
bobhan1 commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2330337039

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328888199

   TeamCity be ut coverage result:
    Function Coverage: 37.86% (8140/21499) 
    Line Coverage: 29.60% (66992/226345)
    Region Coverage: 29.09% (34566/118843)
    Branch Coverage: 24.98% (17806/71270)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/784674ff3d9fc0972862338d505af3a63a340838_784674ff3d9fc0972862338d505af3a63a340838/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328814068

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328930294

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 212381 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 784674ff3d9fc0972862338d505af3a63a340838, data reload: false
   
   query1	922	397	408	397
   query2	6548	2275	2158	2158
   query3	6921	206	205	205
   query4	23582	21647	21546	21546
   query5	19725	6500	6530	6500
   query6	282	224	228	224
   query7	4237	301	324	301
   query8	255	253	228	228
   query9	3036	2624	2577	2577
   query10	424	314	288	288
   query11	15469	15276	15382	15276
   query12	121	81	77	77
   query13	1034	452	443	443
   query14	16881	13160	13669	13160
   query15	356	226	230	226
   query16	6466	292	260	260
   query17	1737	912	934	912
   query18	893	307	316	307
   query19	222	152	148	148
   query20	82	76	76	76
   query21	188	95	94	94
   query22	5184	5072	4902	4902
   query23	34063	33315	33387	33315
   query24	7671	6326	6353	6326
   query25	527	429	433	429
   query26	1264	167	163	163
   query27	2366	297	300	297
   query28	6103	2243	2219	2219
   query29	2891	2850	2823	2823
   query30	245	171	168	168
   query31	949	747	726	726
   query32	68	69	62	62
   query33	447	266	246	246
   query34	851	471	465	465
   query35	1120	918	886	886
   query36	1258	1417	1147	1147
   query37	90	59	59	59
   query38	3027	2894	2911	2894
   query39	1376	1305	1330	1305
   query40	307	97	100	97
   query41	40	38	36	36
   query42	82	85	88	85
   query43	779	790	589	589
   query44	1167	719	721	719
   query45	243	231	234	231
   query46	1241	950	960	950
   query47	1879	1742	1629	1629
   query48	508	412	391	391
   query49	647	379	375	375
   query50	854	611	622	611
   query51	4779	4708	4629	4629
   query52	92	83	85	83
   query53	234	185	181	181
   query54	2652	2462	2490	2462
   query55	90	77	81	77
   query56	258	214	207	207
   query57	1195	1034	1174	1034
   query58	226	204	207	204
   query59	3430	3365	3455	3365
   query60	228	205	204	204
   query61	98	96	98	96
   query62	907	523	466	466
   query63	217	175	191	175
   query64	3528	1626	1395	1395
   query65	3592	3518	3502	3502
   query66	795	409	426	409
   query67	16496	15345	16248	15345
   query68	9281	663	631	631
   query69	482	279	267	267
   query70	1522	1437	1519	1437
   query71	399	311	304	304
   query72	6774	4857	4832	4832
   query73	746	331	318	318
   query74	6290	5846	5893	5846
   query75	5204	3640	3663	3640
   query76	5183	1168	1193	1168
   query77	902	287	249	249
   query78	12371	11685	11905	11685
   query79	6148	640	636	636
   query80	1418	377	389	377
   query81	488	241	236	236
   query82	1625	99	97	97
   query83	176	136	142	136
   query84	259	71	70	70
   query85	890	329	318	318
   query86	342	342	291	291
   query87	3232	3016	3032	3016
   query88	4822	2307	2309	2307
   query89	398	312	310	310
   query90	1962	213	216	213
   query91	168	128	128	128
   query92	60	59	55	55
   query93	5214	571	550	550
   query94	716	212	214	212
   query95	2023	1871	2005	1871
   query96	635	326	328	326
   query97	6426	6392	6336	6336
   query98	237	228	219	219
   query99	2875	918	972	918
   Total cold run time: 314713 ms
   Total hot run time: 212381 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322 [doris]

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #40382:
URL: https://github.com/apache/doris/pull/40382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [branch-2.0] Picks "[Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked #40322" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40382:
URL: https://github.com/apache/doris/pull/40382#issuecomment-2328959605

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 784674ff3d9fc0972862338d505af3a63a340838 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:       21.7 seconds inserted 10000000 Rows, about 460K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org