You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2023/07/12 19:05:35 UTC
[GitHub] [superset] eschutho commented on a diff in pull request #24657: Update base.txt
eschutho commented on code in PR #24657:
URL: https://github.com/apache/superset/pull/24657#discussion_r1261613898
##########
setup.py:
##########
@@ -78,7 +78,7 @@ def get_git_sha() -> str:
"colorama",
"croniter>=0.3.28",
"cron-descriptor",
- "cryptography>=39.0.1, <40",
+ "cryptography>=41.0.0",
Review Comment:
@betodealmeida I saw the Python 3.6 version which shouldn't affect Superset since we're already running on a minimum of 3.9, but do you think that the versions for `OpenSSL` and `LibreSSL` could be an issue? I'm wondering if this change would be considered a potential breaking change for Superset, and if so, if we need to think about cherrying it into 3.0 or wait until 4.0. I checked my local for example, and it seems likely that we could be running LibreSSL < 3.6
##########
setup.py:
##########
@@ -78,7 +78,7 @@ def get_git_sha() -> str:
"colorama",
"croniter>=0.3.28",
"cron-descriptor",
- "cryptography>=39.0.1, <40",
+ "cryptography>=41.0.0",
Review Comment:
@betodealmeida good catch! I saw the Python 3.6 version which shouldn't affect Superset since we're already running on a minimum of 3.9, but do you think that the versions for `OpenSSL` and `LibreSSL` could be an issue? I'm wondering if this change would be considered a potential breaking change for Superset, and if so, if we need to think about cherrying it into 3.0 or wait until 4.0. I checked my local for example, and it seems likely that we could be running LibreSSL < 3.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org