[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4193: fs: Change off_t and related types to int64_t if long long is supported

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #4193:
URL: https://github.com/apache/incubator-nuttx/pull/4193#discussion_r673911505



##########
File path: include/dirent.h
##########
@@ -86,6 +86,14 @@
 #define DT_LNK                    DTYPE_LINK
 #define DT_SOCK                   DTYPE_SOCK
 
+#define dirent64                  dirent
+#define readdir64                 readdir
+#define readdir64_r               readdir_r
+#define scandir64                 scandir
+#define alphasort64               alphasort
+#define versionsort64             versionsort
+#define getdents64                getdents
+

Review comment:
       getdents is Linux specific:
   https://man7.org/linux/man-pages/man2/getdents.2.html
   but @Donny9 is preparing a new patchset to convert dir API to the most conformable implementation in this week like musl:
   https://git.musl-libc.org/cgit/musl/tree/src/dirent
   The change will:
   
   1. Convert fs/dirent to a char driver just like eventfd.
   2. All dirxxx move to libs/libc/dirent
   
   getdents will add in that patchset. The macro here is to avoid him forget to add the definition.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org