You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/30 08:49:52 UTC
[GitHub] [arrow] kou opened a new pull request, #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
kou opened a new pull request, #14003:
URL: https://github.com/apache/arrow/pull/14003
This is a follow-up of ARROW-12175 / #13892 .
We introduced `${PACKAGE}::` namespace to all exported CMake targets
such as `Arrow::arrow_shared` and `Arrow::arrow_static` but we also
provides no namespaced CMake targets such as `arrow_share` and
`arrow_static` as aliases of namespaced CMake targets. But the
backward compatibility feature isn't worked for `_shared`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14003:
URL: https://github.com/apache/arrow/pull/14003#issuecomment-1232481953
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f47f4a73ce17400ca19ea54fc69c19e3...a943f7c5a85345d4ae12a36a7f747bc3/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14003:
URL: https://github.com/apache/arrow/pull/14003#issuecomment-1231687709
@kou Can you update https://github.com/apache/arrow/blob/master/docs/source/cpp/build_system.rst (either in this PR or as a separate JIRA)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14003:
URL: https://github.com/apache/arrow/pull/14003#issuecomment-1231462398
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14003:
URL: https://github.com/apache/arrow/pull/14003#issuecomment-1232481816
Benchmark runs are scheduled for baseline = 359eab59bb12087dbddbdb1dd59ebf48bef42ab6 and contender = 5be95c7cc89cce9a3ccabec7e36d745303f18189. 5be95c7cc89cce9a3ccabec7e36d745303f18189 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ba6eabccd48c4bc78e9ce47e41512c55...a52a6ccbf877410fac0d53a2be77cf8a/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/077e786555c14dc5a84997b781de0ac9...c4d06dd5f02a41f898070446337f9102/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f47f4a73ce17400ca19ea54fc69c19e3...a943f7c5a85345d4ae12a36a7f747bc3/)
[Finished :arrow_down:0.18% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/27c5c54150b647daabc0dec5140f1ca1...9bc1b1e21718432d91d1cf059b0bbe79/)
Buildkite builds:
[Finished] [`5be95c7c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1391)
[Failed] [`5be95c7c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1407)
[Failed] [`5be95c7c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1389)
[Finished] [`5be95c7c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1406)
[Finished] [`359eab59` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1390)
[Failed] [`359eab59` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1406)
[Failed] [`359eab59` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1388)
[Finished] [`359eab59` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1405)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14003:
URL: https://github.com/apache/arrow/pull/14003#issuecomment-1231462372
https://issues.apache.org/jira/browse/ARROW-17565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14003:
URL: https://github.com/apache/arrow/pull/14003#issuecomment-1232364144
Sure. Sorry for missing the doc task.
I'll do it as a separated task (ARROW-17575) because reusing ARROW-17565 for document isn't suitable.
So I merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14003: ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided
Posted by GitBox <gi...@apache.org>.
kou merged PR #14003:
URL: https://github.com/apache/arrow/pull/14003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org