You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/06/14 12:52:19 UTC
[GitHub] [carbondata] ravipesala commented on a change in pull request
#3290: [WIP] Fix creating mv datamap with column name having length more
than 128
ravipesala commented on a change in pull request #3290: [WIP] Fix creating mv datamap with column name having length more than 128
URL: https://github.com/apache/carbondata/pull/3290#discussion_r293794062
##########
File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVHelper.scala
##########
@@ -320,13 +322,16 @@ object MVHelper {
}
def getUpdatedName(name: String): String = {
- val updatedName = name.replace("(", "_")
+ var updatedName = name.replace("(", "_")
.replace(")", "")
.replace(" ", "_")
.replace("=", "")
.replace(",", "")
.replace(".", "_")
.replace("`", "")
+ if (updatedName.length >= CarbonCommonConstants.MAXIMUM_CHAR_LENGTH) {
+ updatedName = updatedName.substring(0, 110) + CarbonCommonConstants.UNDERSCORE + sysNanoTime
Review comment:
Take one counter and increment it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services