You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/16 18:19:13 UTC
[GitHub] [kafka] jsancio opened a new pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
jsancio opened a new pull request #11071:
URL: https://github.com/apache/kafka/pull/11071
Java's FileTreeIterator throws an NoSuchFileException when visting
@metadata-0/partition.metadata.tmp. This is most like do to the
fact that the Log type asynchronously creates and delete that file.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11071:
URL: https://github.com/apache/kafka/pull/11071#issuecomment-881686453
Possibly related: https://github.com/apache/kafka/pull/11056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #11071:
URL: https://github.com/apache/kafka/pull/11071#issuecomment-881693229
> I cherry-picked this to 3.0, but the commit does not apply to 2.8. Since we never created snapshot files in 2.8, are you sure it needs to be present there?
@cmccabe My understanding is that @jolshan and @junrao are planning to cherry pick https://github.com/apache/kafka/pull/11056 to 2.8 because it is a performance regression in 2.8.
Even though there are no snapshots in the metadata directory in 2.8, this code exists and gets executed in 2.8:
https://github.com/apache/kafka/blob/2.8.0/core/src/main/scala/kafka/raft/KafkaMetadataLog.scala#L336-L360
We can either proactive cherry pick this change now or wait until https://github.com/apache/kafka/pull/11056 get cherry picked to 2.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
Posted by GitBox <gi...@apache.org>.
jolshan commented on pull request #11071:
URL: https://github.com/apache/kafka/pull/11071#issuecomment-881735255
Since I've confirmed that we don't use partition.metadata files for the metadata topic in 2.8, I've removed this version from the ticket. Thanks @jsancio for this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #11071:
URL: https://github.com/apache/kafka/pull/11071#issuecomment-881661296
This commit needs to get cherry picked to 2.8 and 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio edited a comment on pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
Posted by GitBox <gi...@apache.org>.
jsancio edited a comment on pull request #11071:
URL: https://github.com/apache/kafka/pull/11071#issuecomment-881693229
> I cherry-picked this to 3.0, but the commit does not apply to 2.8. Since we never created snapshot files in 2.8, are you sure it needs to be present there?
@cmccabe My understanding is that @jolshan and @junrao are planning to cherry pick https://github.com/apache/kafka/pull/11056 to 2.8 because it is a performance regression in 2.8.
Even though there are no snapshots in the metadata directory in 2.8, this code exists and gets executed in 2.8:
https://github.com/apache/kafka/blob/2.8.0/core/src/main/scala/kafka/raft/KafkaMetadataLog.scala#L336-L360
We can either proactively cherry pick this change now or wait until https://github.com/apache/kafka/pull/11056 get cherry picked to 2.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11071:
URL: https://github.com/apache/kafka/pull/11071#issuecomment-881685696
I cherry-picked this to 3.0, but the commit does not apply to 2.8. Since we never created snapshot files in 2.8, are you sure it needs to be present there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #11071: KAFKA-13098: Fix NoSuchFileException during snapshot recovery
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11071:
URL: https://github.com/apache/kafka/pull/11071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org