[GitHub] johnyangk closed pull request #139: [NEMO-248] Validate javadoc in mvn phase

[GitBox <gi...@apache.org>]

johnyangk closed pull request #139: [NEMO-248] Validate javadoc in mvn phase
URL: https://github.com/apache/incubator-nemo/pull/139
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 413b2acc5..72fbd9849 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -26,9 +26,8 @@ jdk:
   - oraclejdk8
 script:
   # the following command line builds the project, runs the tests with coverage and then execute the SonarCloud analysis
-  - if [ "$TRAVIS_PULL_REQUEST" == false ]; then travis_retry mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent verify sonar:sonar -B -q -ff -Dsurefire.useFile=false -Dorg.slf4j.simpleLogger.defaultLogLevel=info; fi
-  - if [ "$TRAVIS_PULL_REQUEST" != false ]; then travis_retry mvn clean verify -B -q -ff -Dsurefire.useFile=false -Dorg.slf4j.simpleLogger.defaultLogLevel=info; fi
-  - mvn clean install -DskipTests && mvn javadoc:javadoc
+  - if [ "$TRAVIS_PULL_REQUEST" == false ]; then travis_retry mvn clean validate; mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent verify sonar:sonar -B -q -ff -Dsurefire.useFile=false -Dorg.slf4j.simpleLogger.defaultLogLevel=info; fi
+  - if [ "$TRAVIS_PULL_REQUEST" != false ]; then travis_retry mvn clean validate; mvn clean verify -B -q -ff -Dsurefire.useFile=false -Dorg.slf4j.simpleLogger.defaultLogLevel=info; fi
 
 notifications:
   slack:
diff --git a/pom.xml b/pom.xml
index 9d7e769f6..1675e9c0b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -247,6 +247,13 @@ under the License.
                         </goals>
                         <phase>site</phase>
                     </execution>
+                    <execution>
+                      <id>test-javadoc</id>
+                      <goals>
+                        <goal>javadoc</goal>
+                      </goals>
+                      <phase>validate</phase>
+                    </execution>
                 </executions>
             </plugin>
             <plugin>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services