You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2025/12/31 09:11:35 UTC
[PR] [MINOR][BUILD] Remove undefined -Pscala-2.13 profile from dev scripts [spark]
yaooqinn opened a new pull request, #53655:
URL: https://github.com/apache/spark/pull/53655
### What changes were proposed in this pull request?
This PR removes the `-Pscala-2.13` profile specification from two dev scripts:
- `dev/lint-scala`
- `dev/scalafmt`
### Why are the changes needed?
The `-Pscala-2.13` profile is not defined in the project's Maven configuration, making these profile references unnecessary and potentially confusing. The default Scala version configured in `pom.xml` will be used instead, simplifying the build process.
### Changes Made
**dev/lint-scala:**
- Removed `-Pscala-2.13 \` line from the scalafmt validation command
**dev/scalafmt:**
- Removed the `VERSION` parameter logic
- Removed `-Pscala-$VERSION` from the Maven command
### Does this PR introduce any user-facing change?
No. This is an internal build script simplification that doesn't affect end users.
### How was this patch tested?
The changes maintain existing functionality by relying on the default Scala version configured in the project's Maven POM files rather than explicitly specifying an undefined profile.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][BUILD] Remove undefined -Pscala-2.13 profile from dev scripts [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #53655: [MINOR][BUILD] Remove undefined -Pscala-2.13 profile from dev scripts
URL: https://github.com/apache/spark/pull/53655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][BUILD] Remove undefined -Pscala-2.13 profile from dev scripts [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #53655:
URL: https://github.com/apache/spark/pull/53655#issuecomment-3704327812
Merged into master. Thanks @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org