You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/10/27 08:43:51 UTC

[GitHub] [kafka] C0urante commented on pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

C0urante commented on PR #12784:
URL: https://github.com/apache/kafka/pull/12784#issuecomment-1293192830

   Thanks @sudeshwasnik, good catch! Would you mind filing a Jira for this so that others who encounter the same bug can track its status and fixed versions?
   
   Regarding the actual changes--I think we should expand unit testing coverage here. The tweak to `ExactlyOnceWorkerSourceTaskTest` does address the case of synchronous offset flush failures (i.e., ones detected before offsets are dispatched to the producer), but it drops coverage for the case of asynchronous offset flush failures (i.e., ones detected after offsets are dispatched to the producer). Can we account for both cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org