[jira] [Commented] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481538#comment-17481538 ] 

ASF subversion and git services commented on SOLR-15124:
--------------------------------------------------------

Commit b6e2757df7ca0648af29052d60eaf3af966568bd in solr's branch refs/heads/main from Nazerke Seidan
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=b6e2757 ]

SOLR-15124: remove /core/admin/[threads|properties|logging] APIs (#198)

Removed three *core* level admin API endpoints because they are ALREADY registered at the node level where they
  really belong: /admin/threads, /admin/properties, /admin/logging

Co-authored-by: Nazerke Seidan <ns...@salesforce.com>
Co-authored-by: David Smiley <ds...@salesforce.com>

> Remove node/container level admin handlers from ImplicitPlugins.json (core level).
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-15124
>                 URL: https://issues.apache.org/jira/browse/SOLR-15124
>             Project: Solr
>          Issue Type: Task
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Blocker
>              Labels: newdev
>             Fix For: 9.0
>
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> There are many very old administrative RequestHandlers registered in a SolrCore that are actually JVM / node / CoreContainer level in nature.  These pre-dated CoreContainer level handlers.  We should (1) remove them from ImplictPlugins.json, and (2) make simplifying tweaks to them to remove that they work at the core level.  For example LoggingHandler has two constructors and a non-final Watcher because it works in these two modalities.  It need only have the one that takes a CoreContainer, and Watcher will then be final.
> /admin/threads
> /admin/properties
> /admin/logging
> Should stay because has core-level stuff:
> /admin/plugins
> /admin/mbeans
> This one:
> /admin/system -- SystemInfoHandler
> returns "core" level information, and also node level stuff.  I propose splitting this one to a CoreInfoHandler to split the logic.  Maybe a separate issue.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org