You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2019/03/20 03:39:00 UTC
[jira] [Commented] (SPARK-27160) Incorrect Literal Casting of
DecimalType in OrcFilters
[ https://issues.apache.org/jira/browse/SPARK-27160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796760#comment-16796760 ]
Dongjoon Hyun commented on SPARK-27160:
---------------------------------------
Hi, [~sadhen]. Thank you so much for this contribution. Next time, please don't set the `Fix Versions` and don't use `Blocker` priority. That is correct for this issue, but there is a guide line for contribution in Apache Spark community. In general, we had better respect the guideline.
- https://spark.apache.org/contributing.html
> Incorrect Literal Casting of DecimalType in OrcFilters
> ------------------------------------------------------
>
> Key: SPARK-27160
> URL: https://issues.apache.org/jira/browse/SPARK-27160
> Project: Spark
> Issue Type: Bug
> Components: SQL
> Affects Versions: 2.4.0
> Reporter: Darcy Shen
> Priority: Blocker
> Labels: correctness
> Fix For: 3.0.0
>
>
> DecimalType Literal should not be casted to Long.
> eg. For `df.filter("x < 3.14")`, assuming df (x in DecimalType) reads from a ORC table and uses the native ORC reader with predicate push down enabled, we will push down the `x < 3.14` predicate to the ORC reader via a SearchArgument.
> OrcFilters will construct the SearchArgument, but not handle the DecimalType correctly.
> The previous impl will construct `x < 3` from `x < 3.14`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org