You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/01/26 08:42:35 UTC
Review Request 42791: Added link to Http Endpoints doc in home.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Repository: mesos
Description
-------
Added link to Http Endpoints doc in home.md.
Diffs
-----
docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
Diff: https://reviews.apache.org/r/42791/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 26, 2016, 8:44 a.m., Joerg Schad wrote:
> > docs/home.md, line 17
> > <https://reviews.apache.org/r/42791/diff/1/?file=1221338#file1221338line17>
> >
> > With https://issues.apache.org/jira/browse/MESOS-4295 we changed the link structure [label](file.md). I.e. s/endpoints/ /endpoints.md
>
> Kevin Klues wrote:
> Even if there is no endpoints.md file? It is a folder with a bunch of .md files inside of it.
I see.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116327
-----------------------------------------------------------
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Kevin Klues <kl...@gmail.com>.
> On Jan. 26, 2016, 8:44 a.m., Joerg Schad wrote:
> > docs/home.md, line 17
> > <https://reviews.apache.org/r/42791/diff/1/?file=1221338#file1221338line17>
> >
> > With https://issues.apache.org/jira/browse/MESOS-4295 we changed the link structure [label](file.md). I.e. s/endpoints/ /endpoints.md
Even if there is no endpoints.md file? It is a folder with a bunch of .md files inside of it.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116327
-----------------------------------------------------------
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116327
-----------------------------------------------------------
docs/home.md (line 17)
<https://reviews.apache.org/r/42791/#comment177371>
With https://issues.apache.org/jira/browse/MESOS-4295 we changed the link structure [label](file.md). I.e. s/endpoints/ /endpoints.md
- Joerg Schad
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review117971
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Feb. 5, 2016, 3:28 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 3:28 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Bugs: MESOS-3831
> https://issues.apache.org/jira/browse/MESOS-3831
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to HTTP Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints/
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 3:28 a.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Changes
-------
Updated based on comments.
Bugs: MESOS-3831
https://issues.apache.org/jira/browse/MESOS-3831
Repository: mesos
Description
-------
Added link to HTTP Endpoints doc in home.md.
Diffs (updated)
-----
docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
Diff: https://reviews.apache.org/r/42791/diff/
Testing
-------
Documentation is live here:
http://c99.millennium.berkeley.edu/documentation/latest/
http://c99.millennium.berkeley.edu/documentation/latest/endpoints/
Thanks,
Kevin Klues
Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review117929
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42955, 42956, 42957, 43215, 43216, 43217, 43218, 43219, 43220, 42790, 43221, 42791]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 4, 2016, 8:38 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 8:38 p.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Bugs: MESOS-3831
> https://issues.apache.org/jira/browse/MESOS-3831
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to HTTP Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints/
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to HTTP Endpoints doc in home.md.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 8:38 p.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Summary (updated)
-----------------
Added link to HTTP Endpoints doc in home.md.
Bugs: MESOS-3831
https://issues.apache.org/jira/browse/MESOS-3831
Repository: mesos
Description (updated)
-------
Added link to HTTP Endpoints doc in home.md.
Diffs (updated)
-----
docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
Diff: https://reviews.apache.org/r/42791/diff/
Testing (updated)
-------
Documentation is live here:
http://c99.millennium.berkeley.edu/documentation/latest/
http://c99.millennium.berkeley.edu/documentation/latest/endpoints/
Thanks,
Kevin Klues
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Kevin Klues <kl...@gmail.com>.
> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > <https://reviews.apache.org/r/42791/diff/1/?file=1221338#file1221338line12>
> >
> > FYI: The links from http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/
I don't know how you generated the link for: http://c99.millennium.berkeley.edu/documentation/latest/version/
It should be http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
which is correct on the site.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
-----------------------------------------------------------
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > <https://reviews.apache.org/r/42791/diff/1/?file=1221338#file1221338line12>
> >
> > FYI: The links from http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/
>
> Kevin Klues wrote:
> I don't know how you generated the link for: http://c99.millennium.berkeley.edu/documentation/latest/version/
> It should be http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
> which is correct on the site.
That is the link which I get from http://c99.millennium.berkeley.edu/documentation/latest/endpoints for version.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
-----------------------------------------------------------
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Kevin Klues <kl...@gmail.com>.
> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > <https://reviews.apache.org/r/42791/diff/1/?file=1221338#file1221338line12>
> >
> > FYI: The links from http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/
>
> Kevin Klues wrote:
> I don't know how you generated the link for: http://c99.millennium.berkeley.edu/documentation/latest/version/
> It should be http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
> which is correct on the site.
>
> Joerg Schad wrote:
> That is the link which I get from http://c99.millennium.berkeley.edu/documentation/latest/endpoints for version.
Strange...
With:
http://c99.millennium.berkeley.edu/documentation/latest/endpoints
I get the same as you.
But with:
http://c99.millennium.berkeley.edu/documentation/latest/endpoints/
(notice the / at the end) I get the correct links
Will look into it.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
-----------------------------------------------------------
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
-----------------------------------------------------------
docs/home.md (line 12)
<https://reviews.apache.org/r/42791/#comment177373>
FYI: The links from http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't seem to work for me... e.g.
http://c99.millennium.berkeley.edu/documentation/latest/version/
- Joerg Schad
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116499
-----------------------------------------------------------
docs/home.md (line 17)
<https://reviews.apache.org/r/42791/#comment177511>
Should capitalize "HTTP" (both times).
- Neil Conway
On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added link to Http Endpoints doc in home.md.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
>
> Diff: https://reviews.apache.org/r/42791/diff/
>
>
> Testing
> -------
>
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42791: Added link to Http Endpoints doc in home.md.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 7:49 a.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Changes
-------
Add links to test docs site in 'Testing' section.
Repository: mesos
Description
-------
Added link to Http Endpoints doc in home.md.
Diffs
-----
docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
Diff: https://reviews.apache.org/r/42791/diff/
Testing (updated)
-------
Documentation is live here:
http://c99.millennium.berkeley.edu/documentation/latest/
http://c99.millennium.berkeley.edu/documentation/latest/endpoints
Thanks,
Kevin Klues