You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "avinashpandeshwar (via GitHub)" <gi...@apache.org> on 2023/06/28 10:32:16 UTC

[GitHub] [airflow] avinashpandeshwar opened a new pull request, #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

avinashpandeshwar opened a new pull request, #32232:
URL: https://github.com/apache/airflow/pull/32232

   While submitting the BigQuery to GCS job, we currently only prefer the project_id of the source table, and completely ignore any provided project_id value as arguments to `BigQueryToGCSOperator`. This is not the expected behaviour, and the provided project_id must be used to submit the job and use that project's resources for computation.
   
   This change considers the project_id parameter while submitting the job, and used the table's project, only if the parameter is not provided.
   
   closes: https://github.com/apache/airflow/issues/32106
   related: https://github.com/apache/airflow/issues/32106
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #32232: Fix BigQuery transfer operators to respect project_id arguments

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1624419295

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1622244987

   Tests are failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

Posted by "eladkal (via GitHub)" <gi...@apache.org>.

eladkal commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1618734790

   Lets please fix all occurrences as mentioned in https://github.com/apache/airflow/issues/32106#issuecomment-1614573765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] avinashpandeshwar commented on pull request #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

Posted by "avinashpandeshwar (via GitHub)" <gi...@apache.org>.

avinashpandeshwar commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1620161120

   @eladkal The PR now includes fixes to both bq_to_gcs and gcs_to_bq ( fixed in multiple places within the operator - regular table, external table, deferred runs, max_id_key calculation ), and incorporates inputs from @bhagany's [comment](https://github.com/apache/airflow/issues/32106#issuecomment-1618909358) and @hussein-awala's [comment](https://github.com/apache/airflow/pull/32095#pullrequestreview-1495708131).
   
   cc @potiuk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1618557507

   Static checks need fixing + rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] avinashpandeshwar commented on pull request #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

Posted by "avinashpandeshwar (via GitHub)" <gi...@apache.org>.

avinashpandeshwar commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1618767738

   @eladkal Sure, that makes sense. Working on merging all the fixes into this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1613223060

   LGTM. Is it possible to add test ? and @Yaro1 -> are you ok with it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bhagany commented on pull request #32232: Fix BigQuery transfer operators to respect project_id arguments

Posted by "bhagany (via GitHub)" <gi...@apache.org>.

bhagany commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1630040366

   Congrats on this, and my thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #32232: Fixing Issue - Provided project_id parameter not getting used to subm…

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1611162890

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #32232: Fix BigQuery transfer operators to respect project_id arguments

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk merged PR #32232:
URL: https://github.com/apache/airflow/pull/32232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] nathadfield commented on pull request #32232: Fix BigQuery transfer operators to respect project_id arguments

Posted by "nathadfield (via GitHub)" <gi...@apache.org>.

nathadfield commented on PR #32232:
URL: https://github.com/apache/airflow/pull/32232#issuecomment-1630259994

   Yes, many thanks from my side too!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org