[GitHub] jerrypeng commented on a change in pull request #3237: fix bug involving consumer producer deadlock in functions

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #3237: fix bug involving consumer producer deadlock in functions
URL: https://github.com/apache/pulsar/pull/3237#discussion_r243703626
 
 

 ##########
 File path: pulsar-functions/instance/src/main/python/contextimpl.py
 ##########
 @@ -133,7 +133,7 @@ def get_output_topic(self):
   def get_output_serde_class_name(self):
     return self.instance_config.function_details.outputSerdeClassName
 
-  def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None):
+  def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None):
 
 Review comment:
   not really since if we don't provide the user to be able to ack on a fail when publishing, the a deadlock with consumers can happen as well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services