You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/24 16:29:04 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #1344: HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity
elek opened a new pull request #1344:
URL: https://github.com/apache/hadoop-ozone/pull/1344
## What changes were proposed in this pull request?
Earlier we introduced a way to mark the inactive pull requests with "pending" label (with the help of /pending comment).
This pull requests introduce a new scheduled build which closes the "pending" pull requests after 21 days of inactivity.
IMPORTANT: Only the pull requests which are pending on the author will be closed.
We should NEVER close a pull requests which are waiting for the attention of a committer.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4140
## How was this patch tested?
on the https://github.com/elek/hadoop-ozone/ fork with this PR: https://github.com/elek/hadoop-ozone/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1344: HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1344:
URL: https://github.com/apache/hadoop-ozone/pull/1344#discussion_r476285423
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: close-prs
+
+on:
+ schedule:
+ - cron: '*/5 * * * *'
Review comment:
I think it would be better to run this workflow once per day instead of every 5 minutes. The list of pending PRs to be closed is filtered only by date (eg. 2020-08-03), not time, so most of the runs would be no-ops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #1344: HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #1344:
URL: https://github.com/apache/hadoop-ozone/pull/1344#discussion_r477245998
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: close-prs
+
+on:
+ schedule:
+ - cron: '*/5 * * * *'
Review comment:
Absolutely, I started with one day but changed it to five minutes to show if it works. Changing back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1344: HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1344:
URL: https://github.com/apache/hadoop-ozone/pull/1344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1344: HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1344:
URL: https://github.com/apache/hadoop-ozone/pull/1344#issuecomment-681821939
Thanks the review @adoroszlai. Let me merge it and :fire: the :bomb:
(I am planning to create a filter to review pending + closed and check it sometimes...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org