[GitHub] [dubbo-go] zouyx commented on a change in pull request #1516: Update triple and some relies version, add consumer registry timeout configuration item

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #1516:
URL: https://github.com/apache/dubbo-go/pull/1516#discussion_r729060501



##########
File path: config/root_config.go
##########
@@ -133,12 +133,17 @@ func registerPOJO() {
 
 func (rc *RootConfig) Init() error {
 	registerPOJO()
-	if err := rc.Logger.Init(); err != nil {
+	if err := rc.Logger.Init(); err != nil { // init default logger

Review comment:
       I think this is useless code.
   
   If you init logger after configcenter , and print success info. Then if not success info of config center then init fail.

##########
File path: go.mod
##########
@@ -11,12 +11,12 @@ require (
 	github.com/apache/dubbo-go-hessian2 v1.9.3
 	github.com/creasty/defaults v1.5.2
 	github.com/dubbogo/go-zookeeper v1.0.3
-	github.com/dubbogo/gost v1.11.17
-	github.com/dubbogo/triple v1.0.6-0.20210909153707-3620c8d2d97c
+	github.com/dubbogo/gost v1.11.18-0.20211011142005-8a95129ef6e2
+	github.com/dubbogo/triple v1.0.7-0.20211012074236-faf8a9baedd6

Review comment:
       use version number pls




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org