You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by na...@apache.org on 2013/06/11 04:25:15 UTC
svn commit: r1491676 - in /hive/trunk:
jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
Author: navis
Date: Tue Jun 11 02:25:15 2013
New Revision: 1491676
URL: http://svn.apache.org/r1491676
Log:
HIVE-4549 : JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM (Prasad Mujumdar via Navis)
Modified:
hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java
hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
Modified: hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java
URL: http://svn.apache.org/viewvc/hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java?rev=1491676&r1=1491675&r2=1491676&view=diff
==============================================================================
--- hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java (original)
+++ hive/trunk/jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java Tue Jun 11 02:25:15 2013
@@ -637,6 +637,14 @@ public class TestJdbcDriver2 extends Tes
for (String checkPattern: tests.keySet()) {
ResultSet rs = (ResultSet)con.getMetaData().getTables("default", null, checkPattern, null);
+ ResultSetMetaData resMeta = rs.getMetaData();
+ assertEquals(5, resMeta.getColumnCount());
+ assertEquals("TABLE_CAT", resMeta.getColumnName(1));
+ assertEquals("TABLE_SCHEM", resMeta.getColumnName(2));
+ assertEquals("TABLE_NAME", resMeta.getColumnName(3));
+ assertEquals("TABLE_TYPE", resMeta.getColumnName(4));
+ assertEquals("REMARKS", resMeta.getColumnName(5));
+
int cnt = 0;
while (rs.next()) {
String resultTableName = rs.getString("TABLE_NAME");
@@ -678,7 +686,7 @@ public class TestJdbcDriver2 extends Tes
ResultSet rs = (ResultSet)con.getMetaData().getSchemas();
ResultSetMetaData resMeta = rs.getMetaData();
assertEquals(2, resMeta.getColumnCount());
- assertEquals("TABLE_SCHEMA", resMeta.getColumnName(1));
+ assertEquals("TABLE_SCHEM", resMeta.getColumnName(1));
assertEquals("TABLE_CATALOG", resMeta.getColumnName(2));
assertTrue(rs.next());
Modified: hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java
URL: http://svn.apache.org/viewvc/hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java?rev=1491676&r1=1491675&r2=1491676&view=diff
==============================================================================
--- hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java (original)
+++ hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java Tue Jun 11 02:25:15 2013
@@ -36,7 +36,7 @@ public class GetSchemasOperation extends
private final String schemaName;
private static final TableSchema RESULT_SET_SCHEMA = new TableSchema()
- .addStringColumn("TABLE_SCHEMA", "Schema name.")
+ .addStringColumn("TABLE_SCHEM", "Schema name.")
.addStringColumn("TABLE_CATALOG", "Catalog name.");
private RowSet rowSet;
Modified: hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java
URL: http://svn.apache.org/viewvc/hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java?rev=1491676&r1=1491675&r2=1491676&view=diff
==============================================================================
--- hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java (original)
+++ hive/trunk/service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java Tue Jun 11 02:25:15 2013
@@ -46,7 +46,7 @@ public class GetTablesOperation extends
private static final TableSchema RESULT_SET_SCHEMA = new TableSchema()
.addStringColumn("TABLE_CAT", "Catalog name. NULL if not applicable.")
- .addStringColumn("TABLE_SCHEMA", "Schema name.")
+ .addStringColumn("TABLE_SCHEM", "Schema name.")
.addStringColumn("TABLE_NAME", "Table name.")
.addStringColumn("TABLE_TYPE", "The table type, e.g. \"TABLE\", \"VIEW\", etc.")
.addStringColumn("REMARKS", "Comments about the table.");