You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/08/12 02:30:20 UTC

[GitHub] [calcite] Enzo-Liu commented on a change in pull request #2480: [CALCITE-4724] clickhouse supportsAliasedValues should be false

Enzo-Liu commented on a change in pull request #2480:
URL: https://github.com/apache/calcite/pull/2480#discussion_r687321688



##########
File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -5986,6 +5986,18 @@ private void checkLiteral2(String expression, String expected) {
         .ok(expected);
   }
 
+  /** Test case for
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-4724">[CALCITE-4724]
+   * As for ClickHouse do not support values in from clause.
+   */

Review comment:
       Updated . 
   And add two more case in `testValues()` and `testValuesEmpty()`, please review again. tks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org