You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Kousuke Saruta (Code Review)" <ge...@cloudera.org> on 2016/11/24 16:37:08 UTC

[kudu-CR] Note to install "which" command in the installation guide in case of building on RHEL/CentOS. I tried to build on Docker container with official CentOS7 image and when I tried to build thirdparty libraries, I caught an error message as follows. + /root/wo 

Kousuke Saruta has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5216

Change subject: Note to install "which" command in the installation guide in case of building on RHEL/CentOS. I tried to build on Docker container with official CentOS7 image and when I tried to build thirdparty libraries, I caught an error message as follows. + /root/wo
......................................................................

Note to install "which" command in the installation guide in case of building on RHEL/CentOS.
I tried to build on Docker container with official CentOS7 image and when I tried to build thirdparty libraries, I caught an error message as follows.
+ /root/work/kudu/thirdparty/preflight.py
Running pre-flight checks
-------------------------
Using C compiler: c++
Using C++ compiler: c++

  (Set $CC and $CXX to change compiler)
-------------------------
Checking for autoconf
Traceback (most recent call last):
  File "/root/work/kudu/thirdparty/preflight.py", line 149, in <module>
    sys.exit(main())
  File "/root/work/kudu/thirdparty/preflight.py", line 141, in main
    check_tools()
  File "/root/work/kudu/thirdparty/preflight.py", line 97, in check_tools
    if subprocess.call(["which", tool], stdout=DEV_NULL, stderr=DEV_NULL) != 0:
  File "/usr/lib64/python2.7/subprocess.py", line 524, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

This message means that "which" command is absent.
Of course, I understand it's very rare case that "which" is absent but I think it's better to note just in case to install "which" command in the installation guide.

Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/5216/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>

[kudu-CR] Note to install "which" command in the installation guide in case of building on RHEL/CentOS.

Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5216

to look at the new patch set (#2).

Change subject: Note to install "which" command in the installation guide in case of building on RHEL/CentOS.
......................................................................

Note to install "which" command in the installation guide in case of building on RHEL/CentOS.

I tried to build on Docker container with official CentOS7 image and 
when I tried to build thirdparty libraries, I caught an error message as follows.

+ /root/work/kudu/thirdparty/preflight.py
Running pre-flight checks
-------------------------
Using C compiler: c++
Using C++ compiler: c++

  (Set $CC and $CXX to change compiler)
-------------------------
Checking for autoconf
Traceback (most recent call last):
  File "/root/work/kudu/thirdparty/preflight.py", line 149, in <module>
    sys.exit(main())
  File "/root/work/kudu/thirdparty/preflight.py", line 141, in main
    check_tools()
  File "/root/work/kudu/thirdparty/preflight.py", line 97, in check_tools
    if subprocess.call(["which", tool], stdout=DEV_NULL, stderr=DEV_NULL) != 0:
  File "/usr/lib64/python2.7/subprocess.py", line 524, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

This message means that "which" command is absent.
Of course, I understand it's very rare case that "which" is absent but I think 
it's better to note just in case to install "which" command in the installation guide.

Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/5216/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Note to install "which" command in the installation guide in case of building on RHEL/CentOS.

Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Kousuke Saruta has posted comments on this change.

Change subject: Note to install "which" command in the installation guide in case of building on RHEL/CentOS.
......................................................................


Patch Set 2:

Thank you for pointing it out. I've fixed it.

-- 
To view, visit http://gerrit.cloudera.org:8080/5216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Note to install "which" command in the installation guide in case of building on RHEL/CentOS.

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Note to install "which" command in the installation guide in case of building on RHEL/CentOS.
......................................................................


Patch Set 2: Verified+1

Unrelated TSAN issues in rpc_stub-test

-- 
To view, visit http://gerrit.cloudera.org:8080/5216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Note to install "which" command in the installation guide in case of building on RHEL/CentOS.

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Note to install "which" command in the installation guide in case of building on RHEL/CentOS.
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Note to install "which" command in the installation guide in case of building on RHEL/CentOS. I tried to build on Docker container with official CentOS7 image and when I tried to build thirdparty libraries, I caught an error message as follows. + /root/wo

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Note to install "which" command in the installation guide in case of building on RHEL/CentOS. I tried to build on Docker container with official CentOS7 image and when I tried to build thirdparty libraries, I caught an error message as follows. + /root/wo
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5216/1//COMMIT_MSG
Commit Message:

Line 7: Note to install "which" command in the installation guide in case of building on RHEL/CentOS.
nit: please format your commit message according to https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

(add a blank line between the first line and the detailed description, and please wrap the description below at 80 chars)


-- 
To view, visit http://gerrit.cloudera.org:8080/5216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Note to install "which" command in the installation guide in case of building on RHEL/CentOS.

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Note to install "which" command in the installation guide in case of building on RHEL/CentOS.
......................................................................


Note to install "which" command in the installation guide in case of building on RHEL/CentOS.

I tried to build on Docker container with official CentOS7 image and 
when I tried to build thirdparty libraries, I caught an error message as follows.

+ /root/work/kudu/thirdparty/preflight.py
Running pre-flight checks
-------------------------
Using C compiler: c++
Using C++ compiler: c++

  (Set $CC and $CXX to change compiler)
-------------------------
Checking for autoconf
Traceback (most recent call last):
  File "/root/work/kudu/thirdparty/preflight.py", line 149, in <module>
    sys.exit(main())
  File "/root/work/kudu/thirdparty/preflight.py", line 141, in main
    check_tools()
  File "/root/work/kudu/thirdparty/preflight.py", line 97, in check_tools
    if subprocess.call(["which", tool], stdout=DEV_NULL, stderr=DEV_NULL) != 0:
  File "/usr/lib64/python2.7/subprocess.py", line 524, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

This message means that "which" command is absent.
Of course, I understand it's very rare case that "which" is absent but I think 
it's better to note just in case to install "which" command in the installation guide.

Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Reviewed-on: http://gerrit.cloudera.org:8080/5216
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M docs/installation.adoc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If02eae6f22a51965120a037cc9a68ddefa418b6c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>