You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Timothy Bish (JIRA)" <ji...@apache.org> on 2010/09/09 21:57:40 UTC

[jira] Created: (AMQNET-281) NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's

NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's
--------------------------------------------------------------------------------------------------

                 Key: AMQNET-281
                 URL: https://issues.apache.org/activemq/browse/AMQNET-281
             Project: ActiveMQ .Net
          Issue Type: Bug
          Components: ActiveMQ, Stomp
    Affects Versions: 1.4.0
            Reporter: Timothy Bish
            Assignee: Timothy Bish
            Priority: Minor
             Fix For: 1.4.0


Some Uri string that are formatted as below can fail parse in the ConnectionFactory BrokerUri set property as the .NET Uri class returns the inner query string portion in this case.

{noformat}
activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)"
activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false"
{noformat}

In the first Uri the Query string returned is:

{noformat}
?keepAlive=false&wireFormat.maxInactivityDuration=1000)
{noformat}

and in the second its

{noformat}
?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false
{noformat}

We need to modify the provider ConnectionFactory code to ensure that it doesn't use the inner Query params from the composite Uri.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQNET-281) NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish updated AMQNET-281:
--------------------------------

    Fix Version/s: 1.4.1
                       (was: 1.4.0)

> NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-281
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-281
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ, Stomp
>    Affects Versions: 1.4.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.1
>
>
> Some Uri string that are formatted as below can fail parse in the ConnectionFactory BrokerUri set property as the .NET Uri class returns the inner query string portion in this case.
> {noformat}
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)"
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false"
> {noformat}
> In the first Uri the Query string returned is:
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)
> {noformat}
> and in the second its
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false
> {noformat}
> We need to modify the provider ConnectionFactory code to ensure that it doesn't use the inner Query params from the composite Uri.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQNET-281) NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQNET-281.
---------------------------------

    Resolution: Fixed

Resolved in trunk and the 1.4.x branches

> NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-281
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-281
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ, Stomp
>    Affects Versions: 1.4.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> Some Uri string that are formatted as below can fail parse in the ConnectionFactory BrokerUri set property as the .NET Uri class returns the inner query string portion in this case.
> {noformat}
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)"
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false"
> {noformat}
> In the first Uri the Query string returned is:
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)
> {noformat}
> and in the second its
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false
> {noformat}
> We need to modify the provider ConnectionFactory code to ensure that it doesn't use the inner Query params from the composite Uri.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQNET-281) NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQNET-281.
---------------------------------

    Resolution: Fixed

Fixed in trunk and 1.4.x branch, added more tests to cover this case.

> NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-281
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-281
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ, Stomp
>    Affects Versions: 1.4.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.1
>
>
> Some Uri string that are formatted as below can fail parse in the ConnectionFactory BrokerUri set property as the .NET Uri class returns the inner query string portion in this case.
> {noformat}
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)"
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false"
> {noformat}
> In the first Uri the Query string returned is:
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)
> {noformat}
> and in the second its
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false
> {noformat}
> We need to modify the provider ConnectionFactory code to ensure that it doesn't use the inner Query params from the composite Uri.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (AMQNET-281) NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQNET-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish reopened AMQNET-281:
---------------------------------


Found some additional issues with this in the Session creation code.

> NMS ActiveMQ and Stomp providers fail to Parse a Uri with params on both the outer and inner Uri's
> --------------------------------------------------------------------------------------------------
>
>                 Key: AMQNET-281
>                 URL: https://issues.apache.org/activemq/browse/AMQNET-281
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ, Stomp
>    Affects Versions: 1.4.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.4.1
>
>
> Some Uri string that are formatted as below can fail parse in the ConnectionFactory BrokerUri set property as the .NET Uri class returns the inner query string portion in this case.
> {noformat}
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)"
> activemq:failover:(tcp://${activemqhost}:61616?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false"
> {noformat}
> In the first Uri the Query string returned is:
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)
> {noformat}
> and in the second its
> {noformat}
> ?keepAlive=false&wireFormat.maxInactivityDuration=1000)?connection.asyncclose=false
> {noformat}
> We need to modify the provider ConnectionFactory code to ensure that it doesn't use the inner Query params from the composite Uri.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.