You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2023/05/17 20:48:52 UTC
[GitHub] [druid] abhishekrb19 opened a new pull request, #14306: Add `examples/` to CI UT/IT ignore
abhishekrb19 opened a new pull request, #14306:
URL: https://github.com/apache/druid/pull/14306
Skip Java UTs and ITs when there are changes to `examples` folder which contain the quickstart tutorials. Also, sort the ignored paths.
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekrb19 commented on pull request #14306: Add `examples/` to CI UT/IT ignore
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on PR #14306:
URL: https://github.com/apache/druid/pull/14306#issuecomment-1552124095
I think GHA is running all the CI checks because of the change to workflow file. I can't think of a way to test this change besides verifying it later in a follow on test PR once this PR is merged to master. The test commit has now been reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #14306: Add `examples/` to CI UT/IT ignore
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #14306:
URL: https://github.com/apache/druid/pull/14306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #14306: Add `examples/` to CI UT/IT ignore
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on PR #14306:
URL: https://github.com/apache/druid/pull/14306#issuecomment-1552325538
>This shouldn’t have been merged. ITs use files in examples directory which is why we don’t skip ITs when there are changes in examples folder.
I guess I assumed that any changes there with test implications would also have changes to java files, though if that's not true we can revert this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekrb19 commented on pull request #14306: Add `examples/` to CI UT/IT ignore
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on PR #14306:
URL: https://github.com/apache/druid/pull/14306#issuecomment-1552331110
@abhishekagarwal87 what part of the Java UTs and ITs rely on the example QuickStart stuff? Do we need some restructuring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #14306: Add `examples/` to CI UT/IT ignore
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #14306:
URL: https://github.com/apache/druid/pull/14306#issuecomment-1552324020
This shouldn’t have been merged. ITs use files in examples directory which
is why we don’t skip ITs when there are changes in examples folder.
On Thu, 18 May 2023 at 6:16 AM, Clint Wylie ***@***.***>
wrote:
> Merged #14306 <https://github.com/apache/druid/pull/14306> into master.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/druid/pull/14306#event-9274705172>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALIWUIQPGAKXNLGAJYO4EDXGVWPHANCNFSM6AAAAAAYFTSL6Q>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #14306: Add `examples/` to CI UT/IT ignore
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #14306:
URL: https://github.com/apache/druid/pull/14306#issuecomment-1556574400
@abhishekrb19 - you will find various examples if you search for `examples` in the integration-test module. The examples are not changed frequently so it's just best to not skip them altogether. can you revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org