[GitHub] [openwhisk] selfxp commented on a change in pull request #4858: Controller endpoint for checking the controller readiness

[GitBox <gi...@apache.org>]

selfxp commented on a change in pull request #4858: Controller endpoint for checking the controller readiness
URL: https://github.com/apache/openwhisk/pull/4858#discussion_r393437709
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala
 ##########
 @@ -151,6 +153,16 @@ class Controller(val instance: ControllerInstanceId,
             .invokerHealth()
             .map(_.count(_.status == InvokerState.Healthy).toJson)
         }
+      } ~ path("ready") {
+        onSuccess(loadBalancer.invokerHealth()) { invokersHealth =>
 
 Review comment:
   I was thinking of doing that originally but that implied writing an Exception Handler and though it would not make a lot of sense of doing that for only one endpoint

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services