You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Wannheden, Knut" <kn...@paranor.ch> on 2003/01/29 15:27:29 UTC

[jelly] [PATCH] check preconditions up front in SetTag

Hi,

I noticed that the <j:set/> tag either requires a "var" or "target" (and
"property") attribute to be specified.  This checking in the implementation,
however, is not very thorough.  Further, the check isn't performed until
after potential body code has been run, which could have undesired side
effects.

Is it preferable to enter patches in bugzilla to just posting them to the
dev list?

Cheers,

--
knut

Re: [jelly] [PATCH] check preconditions up front in SetTag

Posted by James Strachan <ja...@yahoo.co.uk>.
Patch applied, thanks Knut. Sorry it took a while, I've been on the road &
jetlagged lately.

James
-------
http://radio.weblogs.com/0112098/
----- Original Message -----
From: "Wannheden, Knut" <kn...@paranor.ch>
To: "Jakarta-Commons-Dev (E-mail)" <co...@jakarta.apache.org>
Sent: Wednesday, January 29, 2003 2:27 PM
Subject: [jelly] [PATCH] check preconditions up front in SetTag


> Hi,
>
> I noticed that the <j:set/> tag either requires a "var" or "target" (and
> "property") attribute to be specified.  This checking in the
implementation,
> however, is not very thorough.  Further, the check isn't performed until
> after potential body code has been run, which could have undesired side
> effects.
>
> Is it preferable to enter patches in bugzilla to just posting them to the
> dev list?
>
> Cheers,
>
> --
> knut
>
>


----------------------------------------------------------------------------
----


> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org