You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 09:25:14 UTC
[GitHub] [camel-website] Siyubu opened a new pull request #235: Color
contrast dev
Siyubu opened a new pull request #235: Color contrast dev
URL: https://github.com/apache/camel-website/pull/235
. 1. Added a body background color
.2. Added a toolbar background color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#235: Color contrast dev
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #235: Color contrast dev
URL: https://github.com/apache/camel-website/pull/235#discussion_r397067513
##########
File path: README.md
##########
@@ -31,6 +31,21 @@ described in section ["Build with Maven"](#build-with-maven).
### Preparing the tools
+### Chocolatey
+
+For windows users, a beginning step to install yarn and nvm on your local system is through installing chocolatey.
+
+An easy step to step guide to install chocolatey on your local system is as follows:
+1. Open cmd/powershell and run it as administrator.
+
+2. Install with cmd.exe
+
+ > @"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -NoProfile -InputFormat None -ExecutionPolicy Bypass -Command " [System.Net.ServicePointManager]::SecurityProtocol = 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))" && SET "PATH=%PATH%;%ALLUSERSPROFILE%\chocolatey\bin"
+
+3. Install with PowerShell.exe
+
+ > Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))
Review comment:
These instructions often get out of date. I'd prefer that we point to the documentation on how to install tools at the tools website instead of replicating this information here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #235: Color contrast dev
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #235: Color contrast dev
URL: https://github.com/apache/camel-website/pull/235#issuecomment-602017526
Hello,
I closed this Pull request by delating the branch I was working from and
create the new one. On new one I added .yarn to .gitignore list to not be
committed and now I am pulling the new request but still It is failing
immediately . how may I resolve this issue?
*Solange Iyubu*
Student
Carnegie Mellon University in Africa
Tel: +250 785 562 715
On Thu, Mar 19, 2020 at 10:43 AM Andrea Cosentino <no...@github.com>
wrote:
> *@oscerd* requested changes on this pull request.
>
> This PR is incorrect. We don't commit all the .yarn folder content as you
> may see here:
> https://github.com/apache/camel-website/tree/master/antora-ui-camel/.yarn/releases
>
> Please close this one or change it.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-website/pull/235#pullrequestreview-377517314>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALVC76TXWOS7ED2YRTH72RLRIHLLBANCNFSM4LOMPFMQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#235: Color contrast dev
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #235: Color contrast dev
URL: https://github.com/apache/camel-website/pull/235#discussion_r397066611
##########
File path: .gitignore
##########
@@ -14,3 +14,4 @@ resources
.pnp.js
.settings
.hugo_data
+.yarn
Review comment:
Remove this, this directory is where yarn vendored version is kept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #235: Color contrast
dev
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #235: Color contrast dev
URL: https://github.com/apache/camel-website/pull/235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #235: Color contrast dev
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #235: Color contrast dev
URL: https://github.com/apache/camel-website/pull/235#issuecomment-601925969
1. Gave toolbar a background color
2. Gave nav_panel_menu a background color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #235: Color contrast dev
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #235: Color contrast dev
URL: https://github.com/apache/camel-website/pull/235#issuecomment-603175759
I'm closing this, I don't see a way this can be merged without splitting into separate pull requests and explaining the changes made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services