You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:33:04 UTC
[GitHub] [cordova-ios] sushichop opened a new pull request #892: (iOS) Simplify `Cordova.podspec`
sushichop opened a new pull request #892:
URL: https://github.com/apache/cordova-ios/pull/892
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
I want to simplify `Cordova.podspec` since its setting is redundant(`require_arc` is duplicated).
I think this is preferable to ease podspec maintenance.
### Description
<!-- Describe your changes in detail -->
This pull request sets `require_arc` only once.
### Testing
<!-- Please describe in detail how you tested your changes. -->
I executed `pod lib lint` at my local machine using CocoaPods 1.9.5.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on pull request #892: (iOS) Simplify `Cordova.podspec`
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #892:
URL: https://github.com/apache/cordova-ios/pull/892#issuecomment-935559441
#1154 has superseded this PR so I will be closing out this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #892: (iOS) Simplify `Cordova.podspec`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #892:
URL: https://github.com/apache/cordova-ios/pull/892#issuecomment-641208867
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=h1) Report
> Merging [#892](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/062b91dc965c9638f1b65cb18e3898bd81cd7261&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/892/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #892 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 13 13
Lines 1676 1676
=======================================
Hits 1247 1247
Misses 429 429
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=footer). Last update [062b91d...a2c80e9](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #892: (iOS) Simplify `Cordova.podspec`
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #892:
URL: https://github.com/apache/cordova-ios/pull/892#issuecomment-641208867
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=h1) Report
> Merging [#892](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/062b91dc965c9638f1b65cb18e3898bd81cd7261&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/892/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #892 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 13 13
Lines 1676 1676
=======================================
Hits 1247 1247
Misses 429 429
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=footer). Last update [062b91d...a2c80e9](https://codecov.io/gh/apache/cordova-ios/pull/892?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu closed pull request #892: (iOS) Simplify `Cordova.podspec`
Posted by GitBox <gi...@apache.org>.
erisu closed pull request #892:
URL: https://github.com/apache/cordova-ios/pull/892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org