[GitHub] [arrow] nealrichardson commented on pull request #11001: ARROW-12981: [R] Install source package from CRAN alone

[GitBox <gi...@apache.org>]

nealrichardson commented on pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#issuecomment-906502794


   > In the latest commit, I removed `LIBARROW_DOWNLOAD` and added `TEST_OFFLINE_BUILD`. Does that seem right to you?
   
   I think so, but we'll know for sure once we set up CI.
   
   > 
   > I wasn't positive I got the logic right in this section of `configure`:
   > https://github.com/apache/arrow/pull/11001/files#diff-089697faebdb7820ca629a2bb316b878cc0ba18a5bfb0b60996f8dbcd1fa11e7L133-L140
   
   Yes, looks right, I just suggested a further simplification now that we can.
   
   As for CI, there will be an arrow-r-nightly change needed in order to do the rsync etc. that you added to r/Makefile, but the regular CI we want will be in arrow, in our "crossbow" nightly and on-demand builds. There's a bunch of yaml that configures templates [here](https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L980-L1121), if you want to take a stab at it. @jonkeane is back from vacation next week and can help with setting that up too.
   
   Also, I just want to reiterate: this is great, thank you very much for taking the initiative on this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org