You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/03/06 03:44:36 UTC

[kudu-CR] java: ITClient: name background threads

Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12677


Change subject: java: ITClient: name background threads
......................................................................

java: ITClient: name background threads

The ITClient test has several background threads that perform tasks
while the test is running. Naming these threads makes it easier to
understand what happened when wading through the test log.

This patch also squelches an unrelated warning from TempDirUtils due to
not specifying @Override on a Thread's run() method.

Change-Id: I9874b088cc8e77707fc913df3de1d1592c1de6c3
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
2 files changed, 6 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/12677/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9874b088cc8e77707fc913df3de1d1592c1de6c3
Gerrit-Change-Number: 12677
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>

[kudu-CR] java: ITClient: name background threads

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12677 )

Change subject: java: ITClient: name background threads
......................................................................


Patch Set 1: Code-Review+2

If you're in the area, KUDU-2687 is also vexing.


-- 
To view, visit http://gerrit.cloudera.org:8080/12677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9874b088cc8e77707fc913df3de1d1592c1de6c3
Gerrit-Change-Number: 12677
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 06 Mar 2019 05:05:55 +0000
Gerrit-HasComments: No

[kudu-CR] java: ITClient: name background threads

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12677 )

Change subject: java: ITClient: name background threads
......................................................................


Patch Set 1:

> If you're in the area, KUDU-2687 is also vexing.

Interesting, thanks for bringing that to my attention.


-- 
To view, visit http://gerrit.cloudera.org:8080/12677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9874b088cc8e77707fc913df3de1d1592c1de6c3
Gerrit-Change-Number: 12677
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 06 Mar 2019 06:56:38 +0000
Gerrit-HasComments: No

[kudu-CR] java: ITClient: name background threads

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12677 )

Change subject: java: ITClient: name background threads
......................................................................

java: ITClient: name background threads

The ITClient test has several background threads that perform tasks
while the test is running. Naming these threads makes it easier to
understand what happened when wading through the test log.

This patch also squelches an unrelated warning from TempDirUtils due to
not specifying @Override on a Thread's run() method.

Change-Id: I9874b088cc8e77707fc913df3de1d1592c1de6c3
Reviewed-on: http://gerrit.cloudera.org:8080/12677
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
2 files changed, 6 insertions(+), 12 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9874b088cc8e77707fc913df3de1d1592c1de6c3
Gerrit-Change-Number: 12677
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>