You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bugraoz93 (via GitHub)" <gi...@apache.org> on 2025/12/02 20:45:21 UTC
[PR] Move airflowctl-integration-tests to main branch [airflow]
bugraoz93 opened a new pull request, #58972:
URL: https://github.com/apache/airflow/pull/58972
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed pull request #58972: Move airflowctl-integration-tests to main branch
URL: https://github.com/apache/airflow/pull/58972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #58972:
URL: https://github.com/apache/airflow/pull/58972#discussion_r2591040421
##########
.github/workflows/ci-amd-arm.yml:
##########
@@ -732,8 +733,21 @@ jobs:
default-branch: ${{ needs.build-info.outputs.default-branch }}
build-prod-images:
+ # We need to run multiple Airflow Core versions alongside their distributions.
+ # To support this, we must build each version so it can be used in integration
+ # tests through docker-compose.
+ #
+ # We only pull the "current" version to reuse cached images and speed up builds.
+ # All supported versions are then built in parallel.
+ #
+ # More details: https://github.com/apache/infrastructure-actions/blob/main/stash/README.md?plain=1#L33
+ strategy:
+ fail-fast: false
+ matrix:
+ # yamllint disable rule: line-length
+ airflow-core-branch: ${{ fromJSON(needs.build-info.outputs.prod-image-build-matrix) }}
name: Build PROD images
- needs: [build-info, build-ci-images, generate-constraints]
+ needs: [build-info, build-ci-images, generate-constraints, set-prod-image-build-matrix]
Review Comment:
```suggestion
needs: [build-info, build-ci-images, generate-constraints]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #58972:
URL: https://github.com/apache/airflow/pull/58972#issuecomment-3622761695
> Very high commit activity on this PR - is it ready to review or shall I hold-off until stable? :-D
It is on hold until steps are stable. Sorry for the notification flood! I will squash the commits at the end. I’m trying to find the best balance with minimal resources while keeping it easy to cascade across the integration tests stack :smile:
It is also a good refresher for me on our artifact building process, dependencies, and limitations on GitHub Actions. The number of commits probably shows how many times I hit the limitations and dependency walls :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #58972:
URL: https://github.com/apache/airflow/pull/58972#discussion_r2591065461
##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -59,6 +63,16 @@ runs:
key: ${{ inputs.image-type }}-image-save-v3-${{ inputs.platform }}-${{ inputs.python }}
path: "/mnt/"
only-current-branch: 'true'
+ if: inputs.branch != 'main'
Review Comment:
```suggestion
if: inputs.branch != 'main' || inputs.image-type == 'ci'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #58972:
URL: https://github.com/apache/airflow/pull/58972#discussion_r2591076971
##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -59,6 +63,16 @@ runs:
key: ${{ inputs.image-type }}-image-save-v3-${{ inputs.platform }}-${{ inputs.python }}
path: "/mnt/"
only-current-branch: 'true'
+ if: inputs.branch != 'main' || inputs.image-type == 'ci'
Review Comment:
```suggestion
if: inputs.branch != 'main' || (inputs.branch == 'main' && inputs.image-type == 'ci')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #58972:
URL: https://github.com/apache/airflow/pull/58972#issuecomment-3893794262
Closing in favour of this #61822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #58972:
URL: https://github.com/apache/airflow/pull/58972#issuecomment-3623084903
Marked as draft to signal that itis WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed pull request #58972: Move airflowctl-integration-tests to main branch
URL: https://github.com/apache/airflow/pull/58972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #58972:
URL: https://github.com/apache/airflow/pull/58972#issuecomment-3712041808
Testing if the correct image is picked up. I will make it ready and draft again, CI isn't triggered otherwise, while closing and opening again didn't work :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed pull request #58972: Move airflowctl-integration-tests to main branch
URL: https://github.com/apache/airflow/pull/58972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed pull request #58972: Move airflowctl-integration-tests to main branch
URL: https://github.com/apache/airflow/pull/58972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed pull request #58972: Move airflowctl-integration-tests to main branch
URL: https://github.com/apache/airflow/pull/58972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 closed pull request #58972: Move airflowctl-integration-tests to main branch
URL: https://github.com/apache/airflow/pull/58972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move airflowctl-integration-tests to main branch [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #58972:
URL: https://github.com/apache/airflow/pull/58972#issuecomment-3622678842
Very high commit activity on this PR - is it ready to review or shall I hold-off until stable? :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org